Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a exercise to add pipeline parameters #6

Closed
tejal29 opened this issue Sep 7, 2018 · 1 comment
Closed

Define a exercise to add pipeline parameters #6

tejal29 opened this issue Sep 7, 2018 · 1 comment

Comments

@tejal29
Copy link
Contributor

tejal29 commented Sep 7, 2018

Expected Behavior

Define a task which will ask users to define a pipeline param

Actual Behavior

do not exists.

Steps to Reproduce the Problem

none

Additional Info

The task can be something as simple as
" Define a github source code repository https://github.com/knative/build-pipeline to Pipeline paramas"

@tejal29 tejal29 added this to To do in Pipeline CRD via automation Sep 7, 2018
@tejal29 tejal29 changed the title Define a task to add pipeline parameters Define a exercise to add pipeline parameters Sep 11, 2018
@bobcatfish bobcatfish moved this from To do to Ice box in Pipeline CRD Sep 11, 2018
@tejal29
Copy link
Contributor Author

tejal29 commented Oct 12, 2018

we changed to create an exercise to add a Task.
https://github.com/tejal29/build-pipeline/blob/add_user_study/cuj/docs/Exercise2.md

@tejal29 tejal29 closed this as completed Oct 12, 2018
Pipeline CRD automation moved this from Ice box to Done Oct 12, 2018
vdemeester referenced this issue in vdemeester/tektoncd-pipeline Apr 3, 2019
Update to the base fork :: tektoncd/pipeline upstream
chmouel pushed a commit to chmouel/tektoncd-pipeline that referenced this issue Apr 11, 2019
Update to the base fork :: tektoncd/pipeline upstream
popcor255 added a commit to popcor255/pipeline that referenced this issue Mar 30, 2020
# This is the 1st commit message:

change tutorial to getting-started

# This is the commit message tektoncd#2:

update some of the docs

# This is the commit message tektoncd#3:

Remove/Modify local registry setup

This is a getting-started guide and if the user was able to get to this doc. It means they have access to the internet. It is probably easier for the user to create docker hub account then to setup a local image registry. It is probably more secure/convenient to push an image to docker hub with an api token that can revoked then depending on a local registry

# This is the commit message tektoncd#4:

change from we to you

chaning we to you because it is the user doing the tutorial

# This is the commit message tektoncd#5:

change from we to you

# This is the commit message tektoncd#6:

parent 6328deb
author popcor255 <popcor255@gmail.com> 1585337853 -0500
committer popcor255 <popcor255@gmail.com> 1585608100 -0400

Restoring tutorial.md

There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now

Restoring bullet point that outlines the tutorial

changing 'docker' to Docker

remove 'also' from sentences

change tekton piplines to Tekton Pipelines

changed the logs and regred to have docker.io

changed some of the output logs from the results of the instructions because they did not reflect the changes that were made

correct grammar

The namespace does not matter the tutorial will work either way

Change pipeline

Change pipeline and task with inline-yaml

Remove/Modify local registry setup

This is a getting-started guide and if the user was able to get to this doc. It means they have access to the internet. It is probably user for them to create docker account then to setup a local image registry. It is probably more secure to push an image to docker hub with an api token that can revoked then depending on a local registry

change from we to you

chaning we to you because it is the user doing the tutorial

change from we to you

Restoring tutorial.md

There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now

Restoring bullet point that outlines the tutorial

correct grammar

The namespace does not matter the tutorial will work either way

Change pipeline

Change pipeline and task with inline-yaml

# This is the commit message tektoncd#7:

Restoring tutorial.md

There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now

# This is the commit message tektoncd#8:

Restoring bullet point that outlines the tutorial
lumjjb added a commit to lumjjb/pipeline that referenced this issue Feb 23, 2022
* Fix ttl to use right entryExpiry field

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* Add spire entry delete when taskrun is done

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Yongxuanzhang referenced this issue in Yongxuanzhang/pipeline May 2, 2022
# This is the 1st commit message:

change emitting results

# This is the commit message #2:

fix code

# This is the commit message #3:

A few minor cleanups in pkg/reconciler/pipelinerun/pipelinerun_test.go

These just mildly annoyed me, so I thought I'd clean them up.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

# This is the commit message #4:

Instrument e2e pipelinerun_test.go files for logstream

These two (`test/pipelinerun_test.go` and `test/v1alpha1/pipelinerun_test.go`)
weren't done in the last PR, because they were messy and I wanted to get that PR
in. But I had some time this morning, so here they are, which should be the last
things in the e2e tests (other than examples/yamls testing, which are their own
bucket of worms) to be instrumented with `helpers.ObjectNameForTest(t)`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

# This is the commit message #5:

Update tutorial links

We recently updated the introductory tutorial on the documnentation
website. That tutorial covers the same content as the one here. To avoid
duplicated efforts and content drift, I'm linkin that doc here and
replacing the existing content.

Additionally, this removes references to `PipelineResources`.

# This is the commit message #6:

Set git-clone tasks in examples to run as root

Similar to tektoncd@ba2e7f3 -
with tektoncd#4758, `git-init` now uses `ghcr.io/distroless/git` as
its base image, and that image needs to run as root. `git-init` by default does _not_ run as root.
So the two examples using copy-pasted old versions of the `git-clone` catalog task need to be
changed to run as root, or the example tests will keep failing forever.

An equivalent change will be needed in the `git-clone` catalog task once it's bumped to using
`git-init:v0.35.0` or later - currently, it's using `v0.29.0`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

# This is the commit message #7:

adding latest release - 0.35

Updating the table to include the latest release links.

# This is the commit message #8:

Added a unit test for pod status.

Add unit test with large result for setTaskRunStatusBasedOnStepStatus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Pipeline CRD
  
Done
Development

No branches or pull requests

1 participant