Any non-empty Kind with empty APIVersion in TaskRef is a Task

[jerop]

Expected Behavior

Setting Kind to any non-empty string and APIVersion to an empty string in a TaskRef will be considered a validation error.

Note that I don't expect it to be considered a Custom Task because APIVersion is empty.

Actual Behavior

Setting Kind to any non-empty string and APIVersion to an empty string in a TaskRef will be considered a Task, and attempt to create a TaskRun. This is especially a problem if Kind is not set to "Task".

apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  generateName: pr-
spec:
  pipelineSpec:
    tasks:
      - name: greeting
        taskRef:
          kind: Example
          name: foo
---
apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: pr-6whfx
spec:
  pipelineSpec:
    tasks:
    - name: greeting
      taskRef:
        kind: Example
        name: foo
status:
  completionTime: "2023-03-29T16:34:42Z"
  conditions:
  - lastTransitionTime: "2023-03-29T16:34:42Z"
    message: 'Pipeline default/pr-6whfx can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task "foo": failed to get task: tasks.tekton.dev "foo" not found'
    reason: CouldntGetTask
    status: "False"
    type: Succeeded
  pipelineSpec:
    tasks:
    - name: greeting
      taskRef:
        kind: Example
        name: foo

Steps to Reproduce the Problem

1. Create a PipelineRun with a TaskRef where the Kind is set to a non-empty string that's not "Task"
2. Observe the PipelineRun status

[jerop]

We could require that APIVersion has to specified if Kind is specified, then we create a CustomRun - see #6457

[jerop]

cc @pritidesai

[Yongxuanzhang]

/assign

[Yongxuanzhang]

Can we say if TaskRef.Kind is not empty and not NamespacedTaskKind("Task"), and api version is not set, we should return validation error? It may make sense to set Kind to "Task"?

[jerop]

Can we say if TaskRef.Kind is not empty and not NamespacedTaskKind("Task"), and api version is not set, we should return validation error?

Yes, it should be a validation error

It may make sense to set Kind to "Task"?

No, let's not change the user-provided value in "Kind" to "Task" 🙏🏾

[Yongxuanzhang]

Can we say if TaskRef.Kind is not empty and not NamespacedTaskKind("Task"), and api version is not set, we should return validation error?

Yes, it should be a validation error

It may make sense to set Kind to "Task"?

No, let's not change the user-provided value in "Kind" to "Task" 🙏🏾

Sorry I didn't mean we should change that. This issue says "Setting Kind to any non-empty string and APIVersion to an empty string in a TaskRef will be considered a validation error." But if it is set to "Task" by user then it should be a valid case without apiversion?

[jerop]

But if it is set to "Task" by user then it should be a valid case without apiversion?

yes, let's leave that as a valid case, especially given that we default to setting kind to task, so users see that in the spec in the status

[QuanZhang-William]

/assign