Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Steps and Sidecars to container_validation #7442

Open
JeromeJu opened this issue Nov 30, 2023 · 8 comments · May be fixed by #7454 or #7538
Open

Refactor Steps and Sidecars to container_validation #7442

JeromeJu opened this issue Nov 30, 2023 · 8 comments · May be fixed by #7454 or #7538
Assignees
@professorabhay
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Nov 30, 2023 •
edited

Now that we have container_validations, we shall move the Sidecars and Steps validation which are previously under task_validation to this file since they are more tied with container types rather than Task types.

/kind cleanup
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 30, 2023
@JeromeJu
Copy link
Member Author

/good-first-issue

@tekton-robot
Copy link
Collaborator

@JeromeJu:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 30, 2023
@professorabhay
Copy link

Hey, @JeromeJu! I would like to work on this.
Kindly tell me a little bit more about that.

@JeromeJu
Copy link
Member Author

JeromeJu commented Dec 1, 2023

Hey, @JeromeJu! I would like to work on this. Kindly tell me a little bit more about that.

Thanks @professorabhay . I've updated the issue description to be more detailed with links to the changes you might need to make. In general this is to move the validation of struct Step to the file container_validation. No functional changes would be included.

@professorabhay professorabhay linked a pull request Dec 2, 2023 that will close this issue
Open
@dhruval254
Copy link

hey , can i open pr for this ?

@JeromeJu
Copy link
Member Author

hey , can i open pr for this ?

Please feel free to do so. You can also assign me as the reviewer once you put up a PR.

@dhruval254
Copy link

gatcha

@dhruval254
Copy link

dhruval254 commented Dec 28, 2023 •
edited

and can you help a little with Sets.string and Sets.byte issue ?

#7374

@Dhruval7878 Dhruval7878 linked a pull request Dec 28, 2023 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@professorabhay professorabhay

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
4 participants
@JeromeJu @tekton-robot @dhruval254 @professorabhay