Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staleness issue in entrypoint resolver. #1158

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Aug 5, 2019

Changes

There was a bug in the entrypoint resolution logic that allowed for stale values of the
entrypoint to be returned. If an image is supplied by tag, and that tag changes to point
to an image with a new entrypoint, we returned the old one.

This change uses the image digest itself as our cache key, instead of the image name.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

Fixes a bug that allowed Tekton Tasks to run steps with a stale entrypoint.

There was a bug in the entrypoint resolution logic that allowed for stale values of the
entrypoint to be returned. If an image is supplied by tag, and that tag changes to point
to an image with a new entrypoint, we returned the old one.

This change uses the image digest itself as our cache key, instead of the image name.
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Aug 5, 2019
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2019
@ghost
Copy link

ghost commented Aug 5, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Aug 5, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@tekton-robot tekton-robot merged commit eb5c414 into tektoncd:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants