Accept any sidecar termination reason #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fdd91da.
googlebot
added
the
cla: yes
tekton-robot
added
approved
dibyom
approved these changes
Sep 3, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1253 When a sidecar is forcefully exited by the taskrun controller it may error out. This happens because the sidecar is terminated by having its image field rewritten to be tekton's nop container. The nop container is bare bones and probably doesnt contain the entrypoint command configured for the sidecar. When this occurs the container will exit with an error of some kind. On GKE this error's Reason is "ContainerCannotRun" but on MiniShift/OpenShift the error Reason is "Error". The sidecar e2e test previously required a termination Reason of "ContainerCannotRun" or "Completed" but this appears to be too rigid. Instead the test now considers a sidecar that has been terminated for any reason to be a success.
dibyom
reviewed
Sep 3, 2019
|
@sbwsg FYI, I have tested this change on openshift and it was working! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1253
When a sidecar is forcefully exited by the taskrun controller it may
error out. This happens because the sidecar is terminated by having its
image field rewritten to be tekton's nop container. The nop container is
bare bones and probably doesnt contain the entrypoint command configured
for the sidecar. When this occurs the container will exit with an error
of some kind. On GKE this error's Reason is "ContainerCannotRun" but on
MiniShift/OpenShift the error Reason is "Error".
The sidecar e2e test previously required a termination Reason of
ContainerCannotRunorCompletedbut this appears to be too rigid.Instead the test now considers a sidecar that has been terminated for
any reason to be a success.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Includes tests (if functionality changed/added)Includes docs (if user facing)Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.