Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix little typo #1444

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Fix little typo #1444

merged 1 commit into from
Oct 22, 2019

Conversation

tomfrenken
Copy link
Contributor

No description provided.

@tekton-robot tekton-robot requested review from afrittoli and a user October 21, 2019 10:48
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2019
@tekton-robot
Copy link
Collaborator

Hi @tomfrenken. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Should be good to go once the CLA is signed!

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2019
@tomfrenken
Copy link
Contributor Author

@googlebot I signed it!

@ghost
Copy link

ghost commented Oct 22, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Oct 22, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@tomfrenken
Copy link
Contributor Author

@googlebot I signed it!

@afrittoli
Copy link
Member

/approve cancel

@afrittoli afrittoli removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. cla: no labels Oct 22, 2019
@afrittoli
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@afrittoli
Copy link
Member

/approve cancel

@afrittoli afrittoli removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@tomfrenken
Copy link
Contributor Author

@googlebot I signed it!

@ghost
Copy link

ghost commented Oct 22, 2019

@tomfrenken i'm not sure exactly how the CLA bot works but right now when I tell it to scan this PR I get the following error message:

tomfrenken | 54979414+tomfrenken@users.noreply.github.com | need_sender_cla

When you signed the CLA did you use this email address? It's the email used in the author line of your commit.

@afrittoli
Copy link
Member

@tomfrenken i'm not sure exactly how the CLA bot works but right now when I tell it to scan this PR I get the following error message:

tomfrenken | 54979414+tomfrenken@users.noreply.github.com | need_sender_cla

When you signed the CLA did you use this email address? It's the email used in the author line of your commit.

Thanks @sbwsg - I was just chatting with @tomfrenken on slack about the same issue - the email address in the commit message needs to be fixed.

@afrittoli
Copy link
Member

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit and removed cla: no labels Oct 22, 2019
@tomfrenken
Copy link
Contributor Author

Alright, thank y'all for your help with my Google bot odyssey - should work now, just needs the lgtm label back

@afrittoli
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@tekton-robot tekton-robot merged commit b4562d8 into tektoncd:master Oct 22, 2019
@tomfrenken tomfrenken deleted the patch-1 branch October 23, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants