Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resources.md #1506

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Update resources.md #1506

merged 1 commit into from
Oct 31, 2019

Conversation

jonjohnsonjr
Copy link
Contributor

Apologies for the pedantry. The image spec is a different thing from the image layout.

Apologies for the pedantry. The image spec is a different thing from the image layout.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Oct 31, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2019
@tekton-robot
Copy link
Collaborator

Hi @jonjohnsonjr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2019
@jonjohnsonjr
Copy link
Contributor Author

/assign @dlorenc

@ghost
Copy link

ghost commented Oct 31, 2019

/lgtm
/approve

@tekton-robot tekton-robot assigned ghost Oct 31, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@tekton-robot tekton-robot merged commit 13342cc into tektoncd:master Oct 31, 2019
@bobcatfish
Copy link
Collaborator

image

@jonjohnsonjr jonjohnsonjr deleted the patch-1 branch October 31, 2019 20:52
@dlorenc
Copy link
Contributor

dlorenc commented Nov 1, 2019

This is the most @jonjohnsonjr pr ever

@jonjohnsonjr
Copy link
Contributor Author

This is the most @jonjohnsonjr pr ever

Words have meaning!

@bobcatfish
Copy link
Collaborator

amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants