Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track deprecated Beta features w/ earliest date of removal #2532

Merged
merged 1 commit into from May 4, 2020
Merged

Track deprecated Beta features w/ earliest date of removal #2532

merged 1 commit into from May 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 4, 2020

Changes

We don't currently have a centralized place to list the
features that Pipelines has deprecated.

This commit adds a deprecations doc which shows the feature
being deprecated, a link to the release where its deprecation
was announced, and the earliest date by which the feature
will be removed entirely in relation to the announcement.

At the moment I've only listed Beta features that have been
announced as deprecated. I haven't included things which are
still in Alpha or were announced as deprecated prior to
v0.11.0-rc1, since the policy for alpha code was simply that
we'd give 1 release of forewarning.

Submitter Checklist

Release Notes

A list of feature deprecations along with the earliest date of their removal has been added to Pipelines' docs.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 4, 2020
@ghost ghost changed the title Track Beta features we've deprecated and earliest date of removal Track deprecated Beta features w/ earliest date of removal May 4, 2020
We don't currently have a centralized place to list the
features that Pipelines has deprecated.

This commit adds a deprecations doc which shows the feature
being deprecated, a link to the release where its deprecation
was announced, and the earliest date by which the feature
will be removed entirely in relation to the announcement.

At the moment I've only listed Beta features that have been
announced as deprecated. I haven't included things which are
still in Alpha or were announced as deprecated prior to
v0.11.0-rc1, since the policy for alpha code was simply that
we'd give 1 release of forewarning.
@bobcatfish
Copy link
Collaborator

/approve
/lgtm

Didn't seem worth blocking on but would it makes sense for the deprecation doc to link to https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md and maybe vice versa?

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2020
@tekton-robot tekton-robot merged commit a4065de into tektoncd:master May 4, 2020
@ghost
Copy link
Author

ghost commented May 5, 2020

Didn't seem worth blocking on but would it makes sense for the deprecation doc to link to https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md and maybe vice versa?

Good call. We already do link to the policy from this doc (the API Compatibility Policy heading in the table links to it), but we can also add a link from the policy doc to this one.

@ghost ghost mentioned this pull request May 5, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants