Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ko:// in e2e tests to exercices current code 🙃 #2902

Merged
merged 1 commit into from Aug 19, 2020
Merged

Use ko:// in e2e tests to exercices current code 🙃 #2902

merged 1 commit into from Aug 19, 2020

Commits on Aug 18, 2020

  1. Use ko:// in e2e tests to exercices current code 🙃 

    Right now, some examples are exercicing old version of the code, and
definitely never the changes that would be on the images in a PR.
Using `ko://` instead helps with that (e2e tests are using `ko` to
apply the samples).

This link `.ko.yaml` in test folder to use the proper base image (as
`ko create …` seems to be running from the `test` folder).

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
    @vdemeester
    vdemeester committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    0e1ea9b View commit details
    Browse the repository at this point in the history