Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct url in migration doc and modify to main branch in doc urls #3860

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

zhangtbj
Copy link
Contributor

@zhangtbj zhangtbj commented Mar 30, 2021

Changes

  1. When I reviewing the migration doc: https://github.com/tektoncd/pipeline/blob/main/docs/migrating-v1alpha1-to-v1beta1.md
    I found some of the links are wrong, like:

Correct them to the right link

  1. Then I also found some of the Tekton links are still using master, so modify them togheter.

/kind docs

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

Release Notes

Correct the links in migration doc and modify url to use main branch

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 30, 2021
@tekton-robot tekton-robot requested review from afrittoli and a user March 30, 2021 04:04
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2021
@zhangtbj
Copy link
Contributor Author

zhangtbj commented Mar 30, 2021

/kind documentation
/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 30, 2021
@zhangtbj
Copy link
Contributor Author

/retest

1 similar comment
@zhangtbj
Copy link
Contributor Author

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2021
_Note that [the `image` `PipelineResource` is gone in this example](#image-resource) (replaced with
a [`result`](docs/tasks.md#resultes)), and also that now the `Task` doesn't need to know anything
_Note that [the `image` `PipelineResource` is gone in this example](#replacing-an-image-resource) (replaced with
a [`result`](docs/tasks.md#emitting-results)), and also that now the `Task` doesn't need to know anything
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/ is not needed here, both the .md files are under docs/

@pritidesai
Copy link
Member

thanks @zhangtbj for all the fixes, looks good to me except one link is still broken, will be great if you can fix it 🙏

@zhangtbj
Copy link
Contributor Author

Sure thing, @pritidesai .

I have correct it. Thanks for the review!

@pritidesai
Copy link
Member

thank you @zhangtbj
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@tekton-robot tekton-robot merged commit 1f5980f into tektoncd:main Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants