Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update metrics name #3945

Merged
merged 1 commit into from
Jul 6, 2021
Merged

docs: update metrics name #3945

merged 1 commit into from
Jul 6, 2021

Conversation

zhouhaibing089
Copy link
Contributor

The metrics name is prefixed with tekton_pipelines_controller_
according to :9090/metrics output on version v0.22.0.

Also removed one duplicate and added
tekton_pipelines_controller_client_latency histogram metrics.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@zhouhaibing089
docs: update metrics name
d4318db 
The metrics name is prefixed with `tekton_pipelines_controller_`
according to `:9090/metrics` output on version v0.22.0.

Also removed one duplicate and added
`tekton_pipelines_controller_client_latency` histogram metrics.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels May 12, 2021
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2021
@tekton-robot
Copy link
Collaborator

Hi @zhouhaibing089. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2021
@ghost
Copy link

ghost commented May 18, 2021

Is there any way that we could write a test to check these names are as expected? I have no experience with metrics and a simple string search through our codebase doesn't help identify where they come from.

/test pull-tekton-pipeline-integration-tests

@zhouhaibing089
Copy link
Contributor Author

Is there any way that we could write a test to check these names are as expected?

@sbwsg: The name might be generated with a prefix specified, so it is likely not able to search through the exact name.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
@ghost
Copy link

ghost commented Jul 1, 2021

/lgtm

@tekton-robot tekton-robot assigned ghost Jul 1, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021
@zhouhaibing089
Copy link
Contributor Author

/retest

5 similar comments
@zhouhaibing089
Copy link
Contributor Author

/retest

@zhouhaibing089
Copy link
Contributor Author

/retest

@vdemeester
Copy link
Member

/retest

@vdemeester
Copy link
Member

/retest

@vdemeester
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit 226a112 into tektoncd:main Jul 6, 2021
This was referenced Nov 18, 2021
Merged
Merged
Merged
@afrittoli afrittoli mentioned this pull request Nov 18, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouhaibing089 @tekton-robot @afrittoli @vdemeester