Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup integraton tests for multi-arch case #3998

Merged
merged 1 commit into from Jun 2, 2021
Merged

Cleanup integraton tests for multi-arch case #3998

merged 1 commit into from Jun 2, 2021

Conversation

barthy1
Copy link
Member

@barthy1 barthy1 commented Jun 2, 2021

Changes

  • unify usage of alpine/helm image, which is now the one for all architectures (the update is tested for amd64, s390x and ppc64le)
  • remove several tests from skip list for s390x arch

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@barthy1
Cleanup integraton tests for multi-arch case
443a705 
- unify usage of alpine/helm image, which is now the one for all
architectures
- remove several tests from skip list for s390x arch

Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 2, 2021
@tekton-robot tekton-robot requested review from dibyom and jerop June 2, 2021 10:18
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
test/multiarch_utils.go 56.0% 53.8% -2.2

@barthy1
Copy link
Member Author

barthy1 commented Jun 2, 2021

/test tekton-pipeline-unit-tests

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@pritidesai
Copy link
Member

thank you @barthy1
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2021
@tekton-robot tekton-robot merged commit b7f3dba into tektoncd:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@jerop jerop Awaiting requested review from jerop

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@barthy1 @tekton-robot @pritidesai @vdemeester