[cherry-pick] Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workspaces field in Sidecar does not have a JSON annotation, therefore it defaults to pascalcase. This is inconsistent with other fields that are all lowercase. We need to dd the annotations to ensure that json schema generators work correctly. This change annotates the Workspaces field in Sidecar with `json:"workspaces,omitempty"`. Fixes tektoncd#3964 (cherry picked from commits 7f2eafa, 0b80063, a9b729b) We need to cherry pick this change into v0.24 to avoid backwards incompatibility and regressed behavior when we release v0.25.
tekton-robot
added
kind/bug
ghost
approved these changes
Jun 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/lgtm thanks @jerop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Workspaces field in Sidecar does not have a JSON annotation, therefore it defaults to pascalcase. This is inconsistent with other fields that are all lowercase. We need to dd the annotations to ensure that json schema generators work correctly.
This change annotates the Workspaces field in Sidecar with
json:"workspaces,omitempty".Fixes #3964
(cherry picked from commits 7f2eafa, 0b80063, a9b729b)
We need to cherry pick this change into v0.24 to avoid backwards incompatibility and regressed behavior when we release v0.25.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/cc @sbwsg @vdemeester @bobcatfish