Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get default sa from configmap defaultconfigs #4095

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Get default sa from configmap defaultconfigs #4095

merged 1 commit into from
Jul 15, 2021

Conversation

praveen4g0
Copy link

@praveen4g0 praveen4g0 commented Jul 14, 2021 •
edited

Changes

  • upstream/midstream tests verifies for default service account while creating namespace, by default it's hardcoded to default.

  • so if we install pipelines components via operator it sets default-service-account to pipeline in config-defaults config map!

  • so it's safe to use this patch both in upstream/downstream as it actually waits for right service account before it actually start the execution of tests

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 14, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2021
@praveen4g0
Copy link
Author

cc: @nikhil-thomas @piyush-garg

@sm43
Copy link
Member

sm43 commented Jul 14, 2021

/retest

@piyush-garg
Copy link
Contributor

/lgtm
/kind test

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 14, 2021
@piyush-garg
Copy link
Contributor

kind /misc

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 14, 2021
@piyush-garg
Copy link
Contributor

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 14, 2021
@piyush-garg
Copy link
Contributor

/test check-pr-has-kind-label

@piyush-garg
Copy link
Contributor

/label release-note

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 14, 2021
pritidesai
pritidesai approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @praveen4g0

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@tekton-robot tekton-robot merged commit efaa416 into tektoncd:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

@jerop jerop Awaiting requested review from jerop

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@praveen4g0 @sm43 @piyush-garg @tekton-robot @pritidesai