Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename whenexpressions to when expressions #4104

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Jul 19, 2021

Changes

this commit changes references to WhenExpressions in documentation
to when expressions

we use the field when in the pipelines (expressions is not used) so
to make it less confusing to users, we need to rename

this change applies only to the documentation, it doesn't impact the code

closes #3940
closes #4098

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

this commit changes references to `WhenExpressions` in documentation
to `when` expressions

we use the field `when` in the `pipelines` (expressions is not used) so
to make it less confusing to users, we need to rename

this change applies only to the documentation, it doesn't impact the code

closes tektoncd#3940
closes tektoncd#4098
@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 19, 2021
@tekton-robot tekton-robot requested review from a user and vdemeester July 19, 2021 15:27
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2021
@jerop jerop marked this pull request as ready for review July 19, 2021 20:12
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2021
@bobcatfish
Copy link
Collaborator

very thorough!! thanks @jerop 🙏

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@pritidesai
Copy link
Member

sounds good, thank you @jerop
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@tekton-robot tekton-robot merged commit 1a14883 into tektoncd:main Jul 21, 2021
@jerop jerop deleted the rename-when-expressions branch June 11, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
4 participants