Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleContainerTools/skaffold mainline branch is called 'main' other than 'master' #4120

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

kim-fitness
Copy link
Contributor

@kim-fitness kim-fitness commented Jul 27, 2021

GoogleContainerTools/skaffold mainline branch is called 'main' other than 'master'

Changes

docs/tutorial.md

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Docs included if any changes are user facing
  • [N/A] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • [N/A] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 27, 2021
@tekton-robot tekton-robot requested review from a user and vdemeester July 27, 2021 08:18
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2021
@tekton-robot
Copy link
Collaborator

Hi @kim-fitness. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2021
@kim-fitness
Copy link
Contributor Author

/assign @dlorenc

@vdemeester
Copy link
Member

/ok-to-test
/kind documentation
/approve

@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@ghost
Copy link

ghost commented Jul 27, 2021

/lgtm

/test pull-tekton-pipeline-alpha-integration-tests

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot assigned ghost Jul 27, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
@tekton-robot tekton-robot merged commit d03ba20 into tektoncd:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants