Invalidate passing Results between Finally Tasks
#4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/M
Today, passing `Results` between `Finally Tasks` through `when` expressions is not invalidated This change invalidates passing `Results` between `Finally Tasks` through `when` expressions `Finally Tasks` should be executed in parallel after all `Tasks` are done, therefore we cannot have dependencies between `Finally Tasks` A `Pipeline` that passes a `Result` from one `Finally Task` to another `Finally Task` should fail due to validation error Further details in: - [TEP-0004: Task Results in Final Tasks](https://github.com/tektoncd/community/blob/main/teps/0004-task-results-in-final-tasks.md) - [Documentation: Consuming Results in Finally Tasks](https://github.com/tektoncd/pipeline/blob/main/docs/pipelines.md#consuming-task-execution-results-in-finally) This change also refactors the invalidation of `Finally Tasks` to ensure that we capture all the reasons to fail due to invalidation instead of only one reason -- to ensure all invalid syntax in `Finally Tasks` are reported to the user at the first execution Fixes tektoncd#4130
jerop
force-pushed
the
no-deps-in-finally
branch
from
a5e75c2
to
beeb23a
Compare
|
/retest |
|
/test pull-tekton-pipeline-integration-tests |
vdemeester
approved these changes
Aug 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/easycla |
|
@jerop I think the only way to force EasyCLA is to close/re-open (or force push) |
|
@vdemeester aah i see, thank you! |
|
Well, it failed miserably… seems like we have a problem with EasyCLA 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, passing
ResultsbetweenFinally Tasksthroughwhenexpressions is not invalidated
This change invalidates passing
ResultsbetweenFinally TasksthroughwhenexpressionsFinally Tasksshould be executed in parallel after allTasksaredone, therefore we cannot have dependencies between
Finally TasksA
Pipelinethat passes aResultfrom oneFinally Taskto anotherFinally Taskshould fail due to validation errorFurther details in:
This change also refactors the invalidation of
Finally Tasksto ensurethat we capture all the reasons to fail due to invalidation instead of
only one reason -- to ensure all invalid syntax in
Finally Tasksarereported to the user at the first execution
Fixes #4130
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/kind bug