Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/pod: simplify orderContainers returns #4244

Merged
merged 1 commit into from
Sep 21, 2021
Merged

pkg/pod: simplify orderContainers returns #4244

merged 1 commit into from
Sep 21, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Sep 20, 2021 •
edited

Changes

Small refactoring on pkg/pod, simplifying orderSteps function (less arguments to pass, less return vaule).

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 20, 2021
@tekton-robot tekton-robot requested review from dlorenc and a user September 20, 2021 08:57
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint.go 87.2% 87.0% -0.2
pkg/pod/pod.go 91.0% 91.1% 0.1

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@ghost
Copy link

ghost commented Sep 20, 2021

The commit message is quite bare-bones at the moment. Any other info you can include there explaining the motivation for moving the code around?

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2021
@vdemeester vdemeester removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2021
@vdemeester
pkg/pod: simplify orderContainers returns
3a3c91a 
This simplifies a bit the `orderContainers` function to remove an
unecessary return that can be extracted outside. It simplifies the
functino a bit reduces its responsability.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester vdemeester force-pushed the pod-orderstops-mini-refactoring branch from 4a0800b to 3a3c91a Compare September 21, 2021 11:20
@vdemeester
Copy link
Member Author

Updated the commit message a bit.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint.go 87.2% 87.0% -0.2
pkg/pod/pod.go 91.0% 91.1% 0.1

@pritidesai
Copy link
Member

thanks @vdemeester
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2021
@tekton-robot tekton-robot merged commit 4887c02 into tektoncd:main Sep 21, 2021
@vdemeester vdemeester deleted the pod-orderstops-mini-refactoring branch September 21, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @tekton-robot @pritidesai