Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore env var ordering in taskrun reconciler tests #4286

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Ignore env var ordering in taskrun reconciler tests #4286

merged 1 commit into from
Oct 7, 2021

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Oct 6, 2021 •
edited

Changes

fixes #4285

/kind flake

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/flake Categorizes issue or PR as related to a flakey test kind/bug Categorizes issue or PR as related to a bug. labels Oct 6, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2021
@abayer
Ignore env var ordering in taskrun reconciler tests
f0a368e 
fixes tektoncd#4285

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer force-pushed the ignore-env-var-ordering-in-taskrun-reconciler-tests branch from 7ad0d34 to f0a368e Compare October 6, 2021 17:39
@abayer abayer mentioned this pull request Oct 6, 2021
Merged
5 tasks
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 77.2% 77.1% -0.1

@abayer
Copy link
Contributor Author

abayer commented Oct 6, 2021

/remove-kind bug

@tekton-robot tekton-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Oct 6, 2021
@abayer
Copy link
Contributor Author

abayer commented Oct 6, 2021

/assign @vdemeester

@abayer
Copy link
Contributor Author

abayer commented Oct 6, 2021

/retest

5 similar comments
@abayer
Copy link
Contributor Author

abayer commented Oct 6, 2021

/retest

@abayer
Copy link
Contributor Author

abayer commented Oct 6, 2021

/retest

@abayer
Copy link
Contributor Author

abayer commented Oct 6, 2021

/retest

@abayer
Copy link
Contributor Author

abayer commented Oct 6, 2021

/retest

@abayer
Copy link
Contributor Author

abayer commented Oct 6, 2021

/retest

afrittoli
afrittoli reviewed Oct 7, 2021
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2021
vdemeester
vdemeester approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pritidesai
Copy link
Member

dial tcp 10.3.254.65:5000: connect: connection reset by peer

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot merged commit 51b5ed2 into tektoncd:main Oct 7, 2021
@pritidesai pritidesai mentioned this pull request Oct 12, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flakey test lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TaskRun reconciler tests are inconsistent in pod env var ordering
5 participants
@abayer @tekton-robot @pritidesai @vdemeester @afrittoli