Commits on Oct 11, 2021

1. Remove last lingering unnecessarily exported functions …

   fixes tektoncd#3262
   
   There are a few things left, either by design or uncertainty:
   * `pkg/apis/pipeline/v1beta1/conversion_error.go`'s `ConvertErrorf` - I'm not entirely clear on whether this should be around or not. `CannotConvertError` is still used in tests in `pkg/apis/pipeline/v1alpha1`, and the whole thing is just messy enough that I'm not sure what to do.
   * `pkg/apis/pipeline/v1beta1/version_validation.go`'s `ValidateEnabledAPIFields` - it's referenced in `docs/developers/README.md` and I can't tell if that's something that could be intended to eb used in something depending on Tekton, not just in Tekton itself.
   * `pkg/pipelinerunmetrics/injection.go` and `pkg/taskrunmetrics/injection.go`'s `WithInformer` - these are both used as function references in their respective `.../fake/fake.go`s.
   
   Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

   

   abayer committed Oct 11, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 40774e3
   • Browse repository at this point

   Copy the full SHA

   40774e3 View commit details

   Browse the repository at this point in the history