make debug scripts comply with new /tekton/run

[waveywaves]

Changes

• fix debug scripts (in /tekton/debug/scripts) to write entrypoint completion
  files to /tekton/run/<step-no.>/out and /tekton/run/<step-no.>/out.err
  instead of /tekton/run/<step-no.> and /tekton/run/<step-no.>.err.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in or deleted (only if no user facing changes)

fixes #4224

/kind bug

Release Notes

- Bug fixes
Debug scripts were unusable due to addition of the new /tekton/run behavior. This commit makes them usable again.

[ghost]

/test pull-tekton-pipeline-alpha-integration-tests

[ghost]

I think this PR fixes #4224 ?

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[waveywaves]

/kind fix

[waveywaves]

/kind bug

[waveywaves]

@sbwsg I wasn't able to replicate the behavior for #4224 but I was able to find some inconsistencies while testing which I have fixed here. I am still linking this issue to 4224 though as a tracker issue for this PR.

[ghost]

/lgtm

It might be worth adding an alpha e2e test at some point to exercise the debug scripts if possible so we can catch regressions if they're broken with future changes to the entrypoint / Step filesystem.

[ghost]

/test pull-tekton-pipeline-alpha-integration-tests

[waveywaves]

@sbwsg yeah, it would be helpful to have integration tests. I would have already written them if I knew how to architect them for debug.

There might be something very obvious that I am missing because of which I haven't already written them, because testing the scripts involve having a failing taskrun, 'exec'ing into the failed step pod and then checking and executing that script using exec. I am not sure how to achieve this as it is not as straightforward as checking the final state of a taskrun after it's executed. Testing breakpoints is a more involved process. We must discuss this on either an issue or is this something that might need a bigger change to e2e tests for tekton ?

[mattmoor]

/test check-pr-has-kind-label

[waveywaves]

@sbwsg yeah, it would be helpful to have integration tests. I would have already written them if I knew how to architect them for debug.

There might be something very obvious that I am missing because of which I haven't already written them, because testing the scripts involve having a failing taskrun, 'exec'ing into the failed step pod and then checking and executing that script using exec. I am not sure how to achieve this as it is not as straightforward as checking the final state of a taskrun after it's executed. Testing breakpoints is a more involved process. We must discuss this on either an issue or is this something that might need a bigger change to e2e tests for tekton ?

Created #4426 to track this concern