-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the release notes to describe kustomize usage #4509
Conversation
/kind misc |
/test pull-tekton-pipeline-integration-tests |
/test pull-tekton-pipeline-integration-tests /test pull-tekton-pipeline-alpha-integration-tests |
|
||
# Apply Tasks and other resources from Plumbing | ||
# Run this command from the root of the plumbing repo | ||
kubectl kustomize ./tekton/resources/release | kubectl apply -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plumbing covers both namespaces default
and tekton-nightly
and without the namespace created before running this command, it fails with:
Error from server (NotFound): error when creating "STDIN": namespaces "tekton-nightly" not found
Should we include a pre-req here to create the required namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pritidesai ! Updated with expanded comment describing this requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative would be to install only the default
overlay
kubectl kustomize ./tekton/resources/release/overlay/default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update to mention this as an alternative option as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with this alternative!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Prior to this commit our release notes asked the user to `kubectl apply` all the resources from a subdirectory of the plumbing repo. The plumbing repo was updated to use kustomize a while ago, so these notes also needed an update. This commit adds instructions for piping kustomize output to an invocation of kubectl apply.
/lgtm |
Changes
Prior to this commit our release notes asked the user to
kubectl apply
all the resources from a subdirectory of the plumbing repo. The plumbing
repo was updated to use kustomize a while ago, so these notes also
needed an update.
This commit adds instructions for piping kustomize output to an
invocation of kubectl apply.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes