Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the release notes to describe kustomize usage #4509

Merged
merged 1 commit into from Jan 28, 2022
Merged

Update the release notes to describe kustomize usage #4509

merged 1 commit into from Jan 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2022

Changes

Prior to this commit our release notes asked the user to kubectl apply
all the resources from a subdirectory of the plumbing repo. The plumbing
repo was updated to use kustomize a while ago, so these notes also
needed an update.

This commit adds instructions for piping kustomize output to an
invocation of kubectl apply.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 24, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2022
@ghost
Copy link
Author

ghost commented Jan 24, 2022

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 24, 2022
@ghost
Copy link
Author

ghost commented Jan 24, 2022

/test pull-tekton-pipeline-integration-tests

@ghost
Copy link
Author

ghost commented Jan 25, 2022

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-alpha-integration-tests


# Apply Tasks and other resources from Plumbing
# Run this command from the root of the plumbing repo
kubectl kustomize ./tekton/resources/release | kubectl apply -f -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plumbing covers both namespaces default and tekton-nightly and without the namespace created before running this command, it fails with:

Error from server (NotFound): error when creating "STDIN": namespaces "tekton-nightly" not found

Should we include a pre-req here to create the required namespace?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pritidesai ! Updated with expanded comment describing this requirement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative would be to install only the default overlay

kubectl kustomize ./tekton/resources/release/overlay/default

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update to mention this as an alternative option as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with this alternative!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
Prior to this commit our release notes asked the user to `kubectl apply`
all the resources from a subdirectory of the plumbing repo. The plumbing
repo was updated to use kustomize a while ago, so these notes also
needed an update.

This commit adds instructions for piping kustomize output to an
invocation of kubectl apply.
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2022
@dibyom
Copy link
Member

dibyom commented Jan 28, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@tekton-robot tekton-robot merged commit 411d033 into tektoncd:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants