Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Matrix - API Change and Feature Flag #4600

Merged
merged 1 commit into from
Feb 28, 2022
Merged

TEP-0090: Matrix - API Change and Feature Flag #4600

merged 1 commit into from
Feb 28, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Feb 18, 2022 •
edited

Changes

TEP-0090 proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

In this change, we add the matrix field to the PipelineTask specification, which takes a list of Parameters. We gate this field behind the alpha feature gate. We add validation and testing that the field is available in alpha only - we will add further validation in upcoming changes. We also add documentation the API change - we will incrementally add further details as we iterate on the implementation of TEP-0090: Matrix.

/kind feature

Issue: #2050

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Added syntax support for `Matrix` as an alpha feature. It is still in a very early stage of development and is not yet fully functional.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 18, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2022
@jerop jerop force-pushed the tep-0090-api branch 2 times, most recently from 9f59908 to d33696d Compare February 20, 2022 13:20
@jerop
Copy link
Member Author

jerop commented Feb 22, 2022

/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-alpha-integration-tests

@jerop jerop force-pushed the tep-0090-api branch 2 times, most recently from 7e73ffa to fe4fa89 Compare February 22, 2022 16:55
@afrittoli afrittoli added this to the Pipelines v0.34 milestone Feb 22, 2022
@jerop
Copy link
Member Author

jerop commented Feb 22, 2022

TestSidecarTaskSupport is a known flake reported in #2656

/test pull-tekton-pipeline-integration-tests

@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@jerop
Copy link
Member Author

jerop commented Feb 23, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022
@jerop
Copy link
Member Author

jerop commented Feb 24, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2022
@jerop
Copy link
Member Author

jerop commented Feb 25, 2022

@tektoncd/core-maintainers looking for reviews, hoping open one or two more PRs adding more validation before the next release 🙏🏾

pritidesai
pritidesai reviewed Feb 25, 2022
View reviewed changes
docs/matrix.md Outdated Show resolved Hide resolved
@pritidesai
Copy link
Member

thank you @jerop, its looking great, very excited 🎉 I have left a couple of comments 🙏

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2022
pritidesai
pritidesai approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @jerop, very exciting 🎉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2022
@jerop
TEP-0090: Matrix - API Change and Feature Flag
4028cb2 
[TEP-0090][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns`
and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`.

In this change, we add the `matrix` field to the `PipelineTask` specification,
which takes a list of `Parameters`. We gate this field behind the `alpha` feature
gate. We add validation and testing that the field is available in `alpha` only -
we will add further validation in upcoming changes. We also add documentation the
API change - we will incrementally add further details as we iterate on the
implementation of [TEP-0090: Matrix][tep-0090].

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_types.go 94.7% 94.9% 0.2

@ghost
Copy link

ghost commented Feb 28, 2022

Cheers @jerop !

/lgtm

@tekton-robot tekton-robot assigned ghost Feb 28, 2022
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@tekton-robot tekton-robot merged commit 6c86d1e into tektoncd:main Feb 28, 2022
@lbernick lbernick mentioned this pull request Mar 21, 2022
Closed
5 tasks
This was referenced Mar 23, 2022
Closed
Closed
@jerop jerop deleted the tep-0090-api branch June 11, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@pritidesai pritidesai pritidesai approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.34
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jerop @lbernick @pritidesai @tekton-robot @afrittoli