set the param type based on the default value

[pritidesai]

Changes

(pp *ParamSpec) SetDefaults sets the param type based on the default type. But, it is possible that the default value is specified without specifying the type. Also, the else block sets the type to string when default is nil not when the type can not be inferred from the default value (like its explained in the comment):

pipeline/pkg/apis/pipeline/v1beta1/param_types.go

Lines 58 to 64 in 99b8b19

	if pp.Default != nil {
	// propagate the parsed ArrayOrString's type to the parent ParamSpec's type
	pp.Type = pp.Default.Type
	} else {
	// ParamTypeString is the default value (when no type can be inferred from the default value)
	pp.Type = ParamTypeString
	}

The unit tests does not catch this since the test uses v1beta1.NewArrayOrString which sets the type explicitly:

pipeline/pkg/apis/pipeline/v1beta1/param_types.go

Lines 139 to 150 in 99b8b19

	func NewArrayOrString(value string, values ...string) *ArrayOrString {
	if len(values) > 0 {
	return &ArrayOrString{
	Type: ParamTypeArray,
	ArrayVal: append([]string{value}, values...),
	}
	}
	return &ArrayOrString{
	Type: ParamTypeString,
	StringVal: value,
	}
	}

This commit checks if the type is not specified, infer it from the default value and sets the param type based on the default value.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

For pull requests with a release note:

Set the type of the param based on the default value when the type is not specified or cannot be inferred from the default value.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	97.0%	97.3%	0.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	97.0%	97.3%	0.3

[jerop]

thanks @pritidesai 😁

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [jerop,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerop]

workspace-in-sidecar is a known flake: #4169

/test pull-tekton-pipeline-alpha-integration-tests