Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up TestReconcile_CloudEvents YAML parsing #4619

Merged
merged 1 commit into from
Feb 28, 2022
Merged

clean up TestReconcile_CloudEvents YAML parsing #4619

merged 1 commit into from
Feb 28, 2022

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Feb 25, 2022

Changes

Replace Pipeline, PipelineRun, and Task object initialization to use YAMLParser

/kind cleanup

working on #4610

:D picking this up to do a bit of learning. Thank you all for the awesomeness
that is Tekton!!

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

Signed-off-by: jbpratt jbpratt78@gmail.com

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 25, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 25, 2022 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Feb 25, 2022
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2022
@tekton-robot
Copy link
Collaborator

Hi @jbpratt. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai
Copy link
Member

thank you @jbpratt for helping out 👍 Welcome to the community!
/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2022
@pritidesai pritidesai mentioned this pull request Feb 25, 2022
Closed
62 tasks
pritidesai
pritidesai approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @jbpratt 👍

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2022
@pritidesai
Copy link
Member

@jbpratt please update the commit message to include a brief description 🙏

@jbpratt
clean up TestReconcile_CloudEvents YAML parsing
4d0d35f 
Update object initalization (PipelineRun, Pipeline, and Task) to use
YAML parsing in TestReconcile_CloudEvents

Signed-off-by: jbpratt <jbpratt78@gmail.com>
@jbpratt
Copy link
Contributor Author

jbpratt commented Feb 25, 2022

@pritidesai updated!

vdemeester
vdemeester approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pritidesai,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jbpratt
Copy link
Contributor Author

jbpratt commented Feb 28, 2022

/retest

I don't think my changes are related to the failures but I'm investigating now

@tekton-robot tekton-robot merged commit ab647e4 into tektoncd:main Feb 28, 2022
@jbpratt jbpratt deleted the testreconcile-cloudevents branch February 28, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@pritidesai pritidesai pritidesai approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbpratt @tekton-robot @pritidesai @vdemeester