TEP-0090: Refactor execution status validation #4635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
|
The following is the coverage report on the affected files.
|
Today, the execution status validation is long and has duplicated code. We need to validate execution status in matrix, a feature proposed in TEP-0090. To set up for that, we are refactoring the execution status validation in this change which includes splitting up the function and reusing common logic.
jerop
force-pushed
the
tep-0090-validation-3
branch
from
cbff0f7
to
02f5ce6
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on the affected files.
|
pritidesai
reviewed
Mar 1, 2022
pritidesai
reviewed
Mar 1, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/test pull-tekton-pipeline-alpha-integration-tests |
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Today, the execution status validation is long and has duplicated code. We need to validate execution status in matrix, a feature proposed in TEP-0090. To set up for that, we are refactoring the execution status validation in this change which includes splitting up the function and reusing common logic.
cc @pritidesai
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes