Add GetStatusCondition for Run #4658
Conversation
tekton-robot
added
release-note-none
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-integration-tests |
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
Could you also update the comment here? |
|
/test pull-tekton-pipeline-alpha-integration-tests |
Nice catch, thank you! |
The "Run" type does not have a GetStatusCondition which means it doesn't fit the "objectWithCondition" interface used to send cloudevents. Add GetStatusCondition to make the type more consistent with TaskRun and Pipelinerun and make it possible to use it as an "objectWithCondition" when sending events. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
afrittoli
force-pushed
the
run_status_condition
branch
from
0c0617b
to
f111cbf
Compare
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Changes
The "Run" type does not have a GetStatusCondition which means it
doesn't fit the "objectWithCondition" interface used to send
cloudevents.
Add GetStatusCondition to make the type more consistent with
TaskRun and Pipelinerun and make it possible to use it as an
"objectWithCondition" when sending events.
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/cc @vdemeester @lbernick