TEP-0090: Refactor Pipeline Workspaces Validation #4670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this change, we split up the long function for `workspaces` validation and remove duplications. The first function validates the `workspaces` declarations in the `pipeline` - that they are unique and non-empty. The second function validates the usage of `workspaces` in `pipelinetasks` - which is reused for both `tasks` and `finally`.
tekton-robot
added
release-note
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/test pull-tekton-pipeline-alpha-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/lgtm |
vdemeester
approved these changes
Mar 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
jerop
changed the title
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In this change, we split up the long function for
workspacesvalidation and remove duplications.The first function validates the
workspacesdeclarations in thepipeline- that they are unique and non-empty.The second function validates the usage of
workspacesinpipelinetasks- which is reused for bothtasksandfinally./kind cleanup
cc @pritidesai
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes