Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0090: Add validation for PipelineTask context variables #4684

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Mar 17, 2022

Changes

Today, we don't have validation for PipelineTask context variables - we support retries only for now.

In this change, we add validation for PipelineTask context variables.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 17, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
Today, we don't have validation for PipelineTask context variables -
we support retries only for now.

In this change, we add validation for PipelineTask context variables.
@jerop jerop force-pushed the pipelinetask-context-vars branch from 06a38d2 to 2163faf Compare March 17, 2022 16:00
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@jerop
Copy link
Member Author

jerop commented Mar 17, 2022

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-integration-tests

(flakey sidecar tests)

@tekton-robot tekton-robot merged commit 6caa150 into tektoncd:main Mar 17, 2022
@jerop jerop changed the title Add validation for PipelineTask context variables TEP-0090: Add validation for PipelineTask context variables Mar 18, 2022
@jerop jerop deleted the pipelinetask-context-vars branch June 11, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants