Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo about ths I think maybe it should be this #4775

Merged
merged 1 commit into from May 9, 2022
Merged

fix typo about ths I think maybe it should be this #4775

merged 1 commit into from May 9, 2022

Conversation

yuzp1996
Copy link
Contributor

@yuzp1996 yuzp1996 commented Apr 19, 2022 •
edited by dibyom

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2022
@tekton-robot
Copy link
Collaborator

Hi @yuzp1996. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 19, 2022
@AlanGreene
Copy link
Member

Thanks for the PR @yuzp1996
/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2022
@AlanGreene
Copy link
Member

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 19, 2022
@AlanGreene
Copy link
Member

/test pull-tekton-pipeline-integration-tests

@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@yuzp1996
Copy link
Contributor Author

yuzp1996 commented May 8, 2022

Hi, @dibyom @lbernick I am sorry to bother you! Is there anything need to do to merge this PR? Because I am not sure if I lost some steps to merge this PR. If anything I need to do please tell me. Thanks a lot.

@yuzp1996
Copy link
Contributor Author

yuzp1996 commented May 8, 2022

Hi, @dibyom @lbernick I am sorry to bother you! Is there anything need to do to merge this PR? Because I am not sure if I lost some steps to merge this PR. If anything I need to do please tell me. Thanks a lot.

maybe another approve? 😄

@lbernick
Copy link
Member

lbernick commented May 9, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@lbernick
Copy link
Member

lbernick commented May 9, 2022

Is there anything need to do to merge this PR? Because I am not sure if I lost some steps to merge this PR. If anything I need to do please tell me. Thanks a lot.

maybe another approve? 😄

This should merge automatically once all tests pass!

@lbernick
Copy link
Member

lbernick commented May 9, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot merged commit 5e20377 into tektoncd:main May 9, 2022
@yuzp1996
Copy link
Contributor Author

yuzp1996 commented May 9, 2022

@lbernick Thank you very much!

@yuzp1996 yuzp1996 deleted the fix/typo-ths branch May 10, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yuzp1996 @tekton-robot @AlanGreene @lbernick @dibyom