Refactor duplicate code in task_validation_test.go #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, many test functions in this file need to get context based on whether alpha api flag is enabled and this duplicate code chuck appears multiple times. Adding a new helper function will make this code chuck reusable when testing future features that will be developed under alpha feature.
tekton-robot
added
the
release-note
tekton-robot
added
size/M
vdemeester
approved these changes
May 5, 2022
tekton-robot
added
the
approved
lbernick
approved these changes
May 5, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test pull-tekton-pipeline-alpha-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Many test functions in
task_validation_test.gofile need to get context based on whether alpha api flag is enabled and a duplicate code chuck appears multiple times.The new added helper function in this pr will make this code chuck reusable when testing features that will be developed under alpha feature in future.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes