Add V1 Task Golang structs #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XXL
tekton-robot
added
the
do-not-merge/work-in-progress
lbernick
force-pushed
the
v1
branch
2 times, most recently
from
3bde81a
to
6f80d5f
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
This commit adds structs and validation for v1 Task, including results, params, and workspaces. Because we do not yet serve a v1 version of the Task CRD, this change should have no impact. This is copied from v1beta1 with the following exceptions: - omitted PipelineResources - removed deprecated Step and StepTemplate fields - did not copy over Task interface (TaskObject) as ClusterTask is not (yet?) moving to V1
|
The following is the coverage report on the affected files.
|
|
@tektoncd/core-maintainers PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds structs and validation for v1 Task, including results,
params, and workspaces. Because we do not yet serve a v1 version of the Task
CRD, this change should have no impact. This is copied from v1beta1 with the following
exceptions:
Part of #4984.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes