V1: Add conversion for TaskRunSpec.TaskRef.Bundle

[JeromeJu]

This commit adds support for TaskRef.Bundle when converting between
v1beta1 and v1 versions of TaskRef. This allows us to release v1 TaskRun
in a backwards compatible way by ensuring that v1beta1 TaskRuns and
PipelineRuns with Bundle converted to v1 TaskRuns conversion.

part of #4985
/kind misc

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [n/a] Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	96.0%	93.9%	-2.2

[Yongxuanzhang]

/kind misc

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.9%	92.2%	-1.7

[lbernick]

Instead of serializing/deserializing to metadata, we should instead convert this to a remote reference w/ the bundle resolver, since the bundle resolver will be packaged with pipelines. The reason is that we still need to support v1beta1 for 9 months, but we'd like to swap our stored version to v1 as soon as we can. When we swap the stored version to v1 and use it in the reconciler, it's way easier to use the existing functionality for remote resolution than it is to deserialize the bundle reference from annotations.

[lbernick]

I'm not sure though if there's a good way to parse the name to pass to the resolver from the bundle string name (i.e. if we can assume the image name works here). maybe @vdemeester can comment on whether that would work?

[vdemeester]

Instead of serializing/deserializing to metadata, we should instead convert this to a remote reference w/ the bundle resolver, since the bundle resolver will be packaged with pipelines. The reason is that we still need to support v1beta1 for 9 months, but we'd like to swap our stored version to v1 as soon as we can. When we swap the stored version to v1 and use it in the reconciler, it's way easier to use the existing functionality for remote resolution than it is to deserialize the bundle reference from annotations.

I am not sure that I agree with this too much or not 😅, mainly because we don't have any precedent yet on this (we never really converted to new features before). But it's probably fine.

I'm not sure though if there's a good way to parse the name to pass to the resolver from the bundle string name (i.e. if we can assume the image name works here). maybe @vdemeester can comment on whether that would work?

I am not sure I understand this question, it should be straightforward. Today we have the following…

taskRef:
  bundle: foo.bar/baz # image reference
  name: taskName

… that translates to …

taskRef:
  resolver: bundles
  params:
  - name: bundle
    value: foo.bar/baz
  - name: name
    value: taskName
  - name: kind
    value: Task

The kind param should be straightforward to get from the code, the rest is the same.

[lbernick]

thanks! I didn't realize the taskName was the same for both-- this sounds good.

[JeromeJu]

Thanks @lbernick and @vdemeester for the guidance and the discussion.

I would like to confirm, so we don't need to parse or validate the image/bundle name essentially. Instead, will it be sufficient converting to the following configurations?

[lbernick]

Yes, the bundle fields can be passed into taskRef.params without parsing or additional validation.

[lbernick]

thanks Jerome!

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abayer]

/lgtm