Commits on Sep 29, 2022

1. Write TaskRun.Status.TaskSpec with replaced spec on every reconcile run …

   fixes tektoncd#5574
   
   With tektoncd#5537, the call to `applyParamsContextsResultsAndWorkspaces` and setting of `tr.Status.TaskSpec` to the output of that call was moved from happening with every call to `reconcile` to only happening if there wasn't already a pod created. This didn't cause any problems with execution, but it sometimes resulted in `tr.Status.TaskSpec` not getting set properly or getting reset to `nil` on a subsequent `reconcile` run, with the end result that, sometimes, `tr.Status.TaskSpec` would contain the original `TaskSpec` without parameter, result, context, and workspace references being replaced with the corresponding value. This caused flaky failures in the `TestPipelineRunStatusSpec/pipeline_status_spec_updated` e2e test, and integration test failures in Chains (tektoncd/chains#577).
   
   This change moves the PVC creation out of the `if pod == nil {` block that creates the pod if needed, while still checking if `pod` is `nil` before creating the PVC, and brings the `applyParamsContextsResultsAndWorkspaces` call and setting of `tr.Status.TaskSpec` back out of the pod creation block, but after the possible PVC creation.
   
   Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

   

   abayer committed Sep 29, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 8bb5e52
   • Browse repository at this point

   Copy the full SHA

   8bb5e52 View commit details

   Browse the repository at this point in the history