Increase timeout for entrypoint waiter tests #5626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit increases the timeout for entrypoint waiter tests to mitigate the frequency of CI flakes. This doesn't fix the underlying problem (which is likely that it takes longer than the timeout to create and write to a tempfile during CI). However, we don't have a way to reproduce this flake right now, and this change is the easiest way to reduce this test's flake rate. Alternatively, we could rewrite these tests to use filesystem mocks, likely using a library like afero.
tekton-robot
added
kind/flake
tekton-robot
added
the
size/XS
dibyom
approved these changes
Oct 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit increases the timeout for entrypoint waiter tests to mitigate the frequency of CI flakes. This doesn't fix the underlying problem (which is likely that it takes longer than the timeout to create and write to a tempfile during CI). However, we don't have a way to reproduce this flake right now, and this change is the easiest way to reduce this test's flake rate.
Alternatively, we could rewrite these tests to use filesystem mocks, likely using a library like afero.
/kind flake
Closes #5254
(Doesn't actually fix the underlying problem, but if it happens again this issue can be reopened and it'll be a good signal that this increased timeout doesn't address the problem)
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes