update go.mod to Go 1.19 #6216
Merged
update go.mod to Go 1.19 #6216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/hold
tekton-robot
added
size/S
tekton-robot
added
the
approved
tekton-robot
added
size/M
|
@vdemeester should we wait or are we ready to merge this? |
|
@pritidesai we can go 👼🏼 |
|
@vdemeester did you mean to cancel the hold? |
jerop
approved these changes
Mar 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, lbernick, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Checked with @vdemeester offline, thank you @jerop, @vdemeester, @lbernick 👍 /hold cancel |
tekton-robot
added
needs-rebase
tekton-robot
removed
lgtm
tekton-robot
added
size/S
We switched to GO 1.18 in August, 2022 which is now EOL. Our CI has switched to start running with Go 1.19. Given these two motivations, upgrading pipelines to use 1.19 Signed-off-by: pritidesai <pdesai@us.ibm.com>
tekton-robot
added
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We switched to Go 1.18 in August, 2022 (#5338) which is now EOL.
Our CI has switched to start running with Go 1.19: https://github.com/tektoncd/plumbing/blob/main/prow/config.yaml#L1183
Given these two motivations, upgrading pipelines to use 1.19
/kind misc
/hold until we have consensus on this!
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes