Hygiene: cleanup golangci configuration.
#6258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/S
|
/retest-required |
1 similar comment
|
/retest-required |
- Sort linters list. - Replaces deprecated `exclude` configuration for `errcheck` with replacement `exclude-functions` configuration. - Deletes obsolete `depguard` configuration. - Deletes obsolete skip `unused` configuration for `pipelinerun_test.go`. Context: #5899 /kind cleanup <!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 --> - [N/A] Has [Docs](https://github.com/tektoncd/community/blob/main/standards.md#docs) included if any changes are user facing - [N/A] Has [Tests](https://github.com/tektoncd/community/blob/main/standards.md#tests) included if any functionality added or changed - [x] Follows the [commit message standard](https://github.com/tektoncd/community/blob/main/standards.md#commits) - [x] Meets the [Tekton contributor standards](https://github.com/tektoncd/community/blob/main/standards.md) (including functionality, content, code) - [x] Has a kind label. You can add one by adding a comment on this PR that contains `/kind <type>`. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings) - [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release ```release-note NONE ```
pritidesai
reviewed
Mar 2, 2023
pritidesai
reviewed
Mar 2, 2023
pritidesai
reviewed
Mar 2, 2023
pritidesai
reviewed
Mar 2, 2023
| @@ -66,10 +69,6 @@ issues: | |||
| - path: test/pipelinerun_test\.go | |||
There was a problem hiding this comment.
not sure why is this here? its much smaller in size compared to pkg/reconciler/pipelinerun/pipelinerun_test.go with less 1,100 lines.
There was a problem hiding this comment.
I'm not sure what's happening with this one either -- when I remove the exclusion, the unused linter falsely identifies several in-use functions as unused. 🤷🏾
pritidesai
reviewed
Mar 2, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Thanks for all the cleanup @bendory ! 🙏 /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
excludeconfiguration forerrcheckwith replacementexclude-functionsconfiguration.depguardconfiguration.unusedconfiguration forpipelinerun_test.go.Context: #5899
/kind cleanup
Submitter Checklist
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes