refactor getTaskRunCreations in the pipelineRun reconciler test suite #6293

airycanon · 2023-03-05T07:28:49Z

Changes

This commit refactors the getTaskRunCreations function in the pipelineRun reconciler test suite. Previously, during PipelineRun reconciliation, getTaskRunCreations checked for the creation action of a TaskRun. With this update, the function first retrieves the TaskRun created by the PipelineRun, and then checks for the creation result of the TaskRun.

closes: #6143

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

linux-foundation-easycla · 2023-03-05T07:28:52Z

The committers listed above are authorized under a signed CLA.

✅ login: airycanon / name: Yukun Wang (7ad3197)

tekton-robot · 2023-03-05T07:28:57Z

Hi @airycanon. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

airycanon · 2023-03-05T07:46:15Z

/label area/testing

tekton-robot · 2023-03-05T07:46:16Z

@airycanon: The label(s) /label area/testing cannot be applied. These labels are supported: ``

In response to this:

/label area/testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

airycanon · 2023-03-05T07:47:59Z

/area testing

airycanon · 2023-03-05T08:02:45Z

/kind cleanup

airycanon · 2023-03-05T09:23:23Z

/test check-pr-has-kind-label

tekton-robot · 2023-03-05T09:23:37Z

@airycanon: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

airycanon · 2023-03-05T09:27:24Z

/test pull-tekton-pipeline-go-coverage-df

tekton-robot · 2023-03-05T09:27:38Z

@airycanon: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dibyom · 2023-03-06T17:36:43Z

/ok-to-test

JeromeJu · 2023-03-06T20:36:11Z

Thanks @airycanon for the contributions!
/assign

JeromeJu · 2023-03-06T20:36:23Z

/meow

tekton-robot · 2023-03-06T20:36:25Z

@JeromeJu:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JeromeJu

Thanks @airycanon . this looks good to me

pkg/reconciler/pipelinerun/pipelinerun_test.go

airycanon · 2023-03-07T01:38:11Z

/assign @vdemeester

lbernick

thank you @airycanon!

pkg/reconciler/pipelinerun/pipelinerun_test.go

airycanon · 2023-04-12T09:32:31Z

@lbernick I have made changes to the code in response to the comments you raised. Could you please review my code again and provide any further feedback? Thanks.

airycanon · 2023-04-14T07:49:57Z

Hi @lbernick, could you please review my pull request one more time? I made changes based on your feedback and want to make sure it meets your standards. Thanks!

lbernick

thank you for these changes! I think this will make our tests much easier to understand.

tekton-robot · 2023-04-14T13:16:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

airycanon · 2023-04-17T02:11:16Z

@JeromeJu @lbernick This PR seems to be ready now, could you please add an LGTM label to it?

lbernick · 2023-04-18T13:20:36Z

We typically have different people approve and LGTM, but maybe @JeromeJu can add LGTM now since he's gotten LGTM permissions since first approving this!

JeromeJu · 2023-04-18T15:04:32Z

Thanks for the cleanup!
/lgtm

tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 5, 2023

tekton-robot requested a review from jerop March 5, 2023 07:28

tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2023

tekton-robot requested a review from lbernick March 5, 2023 07:28

tekton-robot added the area/testing Issues or PRs related to testing label Mar 5, 2023

airycanon changed the title ~~refactor getTaskRunCreations to be explicit on getting TaskRuns~~ refactor getTaskRunCreations to be explicit on getting TaskRuns in the pipelineRun reconciler test suite Mar 5, 2023

airycanon changed the title ~~refactor getTaskRunCreations to be explicit on getting TaskRuns in the pipelineRun reconciler test suite~~ refactor getTaskRunCreations in the pipelineRun reconciler test suite Mar 5, 2023

tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 5, 2023

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2023

tekton-robot assigned JeromeJu Mar 6, 2023

JeromeJu approved these changes Mar 6, 2023

View reviewed changes

pkg/reconciler/pipelinerun/pipelinerun_test.go Show resolved Hide resolved

tekton-robot assigned vdemeester Mar 7, 2023

lbernick reviewed Mar 7, 2023

View reviewed changes

pkg/reconciler/pipelinerun/pipelinerun_test.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/pipelinerun_test.go Outdated Show resolved Hide resolved

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 8, 2023

airycanon requested review from lbernick and removed request for jerop March 12, 2023 18:50

lbernick reviewed Mar 15, 2023

View reviewed changes

airycanon requested a review from lbernick April 10, 2023 06:43

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023

refactor getTaskRunCreations to be explicit on getting TaskRuns

191453d

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2023

lbernick approved these changes Apr 14, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023

tekton-robot merged commit 50fa5f1 into tektoncd:main Apr 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor getTaskRunCreations in the pipelineRun reconciler test suite #6293

refactor getTaskRunCreations in the pipelineRun reconciler test suite #6293

airycanon commented Mar 5, 2023 •

edited

Loading

linux-foundation-easycla bot commented Mar 5, 2023 •

edited

Loading

tekton-robot commented Mar 5, 2023

airycanon commented Mar 5, 2023 •

edited

Loading

tekton-robot commented Mar 5, 2023

airycanon commented Mar 5, 2023

airycanon commented Mar 5, 2023

airycanon commented Mar 5, 2023

tekton-robot commented Mar 5, 2023

airycanon commented Mar 5, 2023

tekton-robot commented Mar 5, 2023

dibyom commented Mar 6, 2023

JeromeJu commented Mar 6, 2023

JeromeJu commented Mar 6, 2023

tekton-robot commented Mar 6, 2023

JeromeJu left a comment

airycanon commented Mar 7, 2023

lbernick left a comment

airycanon commented Apr 12, 2023

airycanon commented Apr 14, 2023

lbernick left a comment

tekton-robot commented Apr 14, 2023

airycanon commented Apr 17, 2023

lbernick commented Apr 18, 2023

JeromeJu commented Apr 18, 2023

refactor getTaskRunCreations in the pipelineRun reconciler test suite #6293

refactor getTaskRunCreations in the pipelineRun reconciler test suite #6293

Conversation

airycanon commented Mar 5, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

linux-foundation-easycla bot commented Mar 5, 2023 • edited Loading

tekton-robot commented Mar 5, 2023

airycanon commented Mar 5, 2023 • edited Loading

tekton-robot commented Mar 5, 2023

airycanon commented Mar 5, 2023

airycanon commented Mar 5, 2023

airycanon commented Mar 5, 2023

tekton-robot commented Mar 5, 2023

airycanon commented Mar 5, 2023

tekton-robot commented Mar 5, 2023

dibyom commented Mar 6, 2023

JeromeJu commented Mar 6, 2023

JeromeJu commented Mar 6, 2023

tekton-robot commented Mar 6, 2023

JeromeJu left a comment

Choose a reason for hiding this comment

airycanon commented Mar 7, 2023

lbernick left a comment

Choose a reason for hiding this comment

airycanon commented Apr 12, 2023

airycanon commented Apr 14, 2023

lbernick left a comment

Choose a reason for hiding this comment

tekton-robot commented Apr 14, 2023

airycanon commented Apr 17, 2023

lbernick commented Apr 18, 2023

JeromeJu commented Apr 18, 2023

airycanon commented Mar 5, 2023 •

edited

Loading

linux-foundation-easycla bot commented Mar 5, 2023 •

edited

Loading

airycanon commented Mar 5, 2023 •

edited

Loading