Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: added a note on pulling task image from private repo #6426

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

adelmoradian
Copy link
Contributor

Changes

Added a note on pulling task image from private repo.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 23, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2023
@tekton-robot
Copy link
Collaborator

Hi @adelmoradian. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adelmoradian
Copy link
Contributor Author

/assign @jerop

@jerop
Copy link
Member

jerop commented Mar 24, 2023

@adelmoradian please sign the CLA: #6426 (comment)

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @adelmoradian, and welcome to the Tekton community!

/meow

Please add more details in the commit message, for example:

doc: added a note on pulling task image from private repo

if a task uses an image from a private repo, then `imagePullSecrets`
must be provided at runtime - added note to the tasks docs 

Standards: https://github.com/tektoncd/community/blob/main/standards.md#commit-messages

docs/tasks.md Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

@jerop: cat image

In response to this:

Thanks for the contribution @adelmoradian, and welcome to the Tekton community!

/meow

Please add more details in the commit message, for example:

doc: added a note on pulling task image from private repo

if a task uses an image from a private repo, then `imagePullSecrets`
must be provided at runtime - added note to the tasks docs 

Standards: https://github.com/tektoncd/community/blob/main/standards.md#commit-messages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adelmoradian adelmoradian force-pushed the private-task-image branch 2 times, most recently from 6502ea8 to 5cb77b9 Compare March 26, 2023 19:28
prior to this, docs were not clear on how to use a private image
for a task - issue tektoncd#3604

if a task uses an image from a private repo, then `imagePullSecrets`
must be provided at runtime via `podTemplate` - added note to the tasks docs
@adelmoradian
Copy link
Contributor Author

@jerop amended the commit message and signed the CLA!

@dibyom
Copy link
Member

dibyom commented Mar 27, 2023

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2023
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @adelmoradian!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023
@jerop jerop added this to the Pipelines v0.47 milestone Apr 20, 2023
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2023
@tekton-robot tekton-robot merged commit 8fb5999 into tektoncd:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants