Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up and refactor isCustomTask #6447

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Commits on Mar 30, 2023

  1. Split up and refactor isCustomTask

    In this change, we clean up the `isCustomTask` function:
    - Remove unused `context.Context`.
    - Remove the check that either `TaskRef` or `TaskSpec` is specified
    because we check that way before - see [code].
    - Define the check that `TaskRef` is a `CustomTask` as a member function
    of `TaskRef`; and add tests for the member function.
    - Define the check that `TaskSpec` is a `CustomTask` as a member function
    of `TaskSpec`; and add tests for the member function.
    - Update the docstring for `Kind` and `APIVersion` in `TaskRef`.
    
    There are no user-facing changes in this commit.
    
    [code]: https://github.com/tektoncd/pipeline/blob/b7d815a9d8528547994f65da097050f472bbb8b2/pkg/apis/pipeline/v1beta1/pipeline_types.go#L216-L227
    jerop committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    6ee09cb View commit details
    Browse the repository at this point in the history