Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed nil panic scenarios. #6465

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Fixed nil panic scenarios. #6465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/timeout_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,13 @@ spec:
if err != nil {
t.Errorf("Error getting Taskrun: %v", err)
}
if tr == nil {
t.Fatalf("no TaskRun details available")
}
if tr.Status.Steps[0].Terminated == nil {
if tr.Status.Steps[0].Terminated.Reason != "Completed" {
t.Errorf("step-no-timeout should not have been terminated")
}
t.Errorf("step-no-timeout should have Completed.")
} else if tr.Status.Steps[0].Terminated.Reason != "Completed" {
t.Errorf("step-no-timeout should not have been terminated")
}
if tr.Status.Steps[2].Terminated == nil {
t.Errorf("step-canceled should have been canceled after step-timeout timed out")
Expand Down