Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0089] SPIRE for non-falsifiable provenance - IsSpireEnabled #6524

Merged
merged 2 commits into from
Apr 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/apis/config/feature_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,11 @@ func CheckAlphaOrBetaAPIFields(ctx context.Context) bool {
return cfg.FeatureFlags.EnableAPIFields == AlphaAPIFields || cfg.FeatureFlags.EnableAPIFields == BetaAPIFields
}

// IsSpireEnabled checks if non-falsifiable provenance is enforced through SPIRE
func IsSpireEnabled(ctx context.Context) bool {
return FromContextOrDefaults(ctx).FeatureFlags.EnforceNonfalsifiability == EnforceNonfalsifiabilityWithSpire
}

func setEnableAPIFields(ctx context.Context, want string) context.Context {
featureFlags, _ := NewFeatureFlagsFromMap(map[string]string{
"enable-api-fields": want,
Expand Down
54 changes: 54 additions & 0 deletions pkg/apis/config/feature_flags_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,60 @@ func TestCheckAlphaOrBetaAPIFields(t *testing.T) {
}
}

func TestIsSpireEnabled(t *testing.T) {
testCases := []struct {
name string
configmap map[string]string
expectedIsSpireEnabled bool
jagathprakash marked this conversation as resolved.
Show resolved Hide resolved
}{{
name: "when enable-api-fields is set to beta and non-falsifiablity is not set.",
configmap: map[string]string{
"enable-api-fields": "beta",
"enforce-nonfalsifiability": config.EnforceNonfalsifiabilityNone,
},
expectedIsSpireEnabled: false,
}, {
name: "when enable-api-fields is set to beta and non-falsifiability is set to 'spire'",
configmap: map[string]string{
"enable-api-fields": "beta",
"enforce-nonfalsifiability": config.EnforceNonfalsifiabilityWithSpire,
},
expectedIsSpireEnabled: false,
}, {
name: "when enable-api-fields is set to alpha and non-falsifiability is not set",
configmap: map[string]string{
"enable-api-fields": "alpha",
"enforce-nonfalsifiability": config.EnforceNonfalsifiabilityNone,
},
expectedIsSpireEnabled: false,
}, {
name: "when enable-api-fields is set to alpha and non-falsifiability is set to 'spire'",
configmap: map[string]string{
"enable-api-fields": "alpha",
jerop marked this conversation as resolved.
Show resolved Hide resolved
"enforce-nonfalsifiability": config.EnforceNonfalsifiabilityWithSpire,
},
expectedIsSpireEnabled: true,
}}
ctx := context.Background()
store := config.NewStore(logging.FromContext(ctx).Named("config-store"))
for _, tc := range testCases {
featureflags := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "feature-flags",
},
Data: tc.configmap,
}
store.OnConfigChanged(featureflags)
ctx = store.ToContext(ctx)
want := tc.expectedIsSpireEnabled
got := config.IsSpireEnabled(ctx)

if want != got {
t.Errorf("IsSpireEnabled() = %t, want %t", got, want)
}
}
}

func verifyConfigFileWithExpectedFeatureFlagsConfig(t *testing.T, fileName string, expectedConfig *config.FeatureFlags) {
t.Helper()
cm := test.ConfigMapFromTestFile(t, fileName)
Expand Down