Use the system-installed version of golangci-lint.

[bendory]

Changes

See this thread: https://tektoncd.slack.com/archives/CJ4ERJWAU/p1681920119203019

Context: #5899

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [N/A] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• [N/A] Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

/kind misc
/assign vdemeester

Release Notes

NONE

[vdemeester]

So… doing that would break the Makefile though 😅
I would rather update the version here or adapt the presubmit.sh file ? (or remove the GOLANGCILINT variable from the Makefile.

cc @afrittoli @abayer

Basically, we need to decide what is the source of truth for the CI. As of today, it's the one in the Makefile, so doing make golangci-lint gives you the guarantee you will have the same version as you do on the CI (no matter what the container image or the system has installed) — and I do like that to be honest 😝

[bendory]

So… doing that would break the Makefile though 😅 I would rather update the version here or adapt the presubmit.sh file ? (or remove the GOLANGCILINT variable from the Makefile.

Yeah, you're right. 😢

Can we go forward with this to unblock me while you sort out the larger issue?

[vdemeester]

Yes, as is (with updating the GOLANGCI_VERSION in the Makefile), let's go
/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment