Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0142: Introduce StepAction referencing syntax in Steps #7284

Merged
merged 1 commit into from
Oct 27, 2023
Merged

TEP-0142: Introduce StepAction referencing syntax in Steps #7284

merged 1 commit into from
Oct 27, 2023

Conversation

chitrangpatel
Copy link
Member

@chitrangpatel chitrangpatel commented Oct 25, 2023 •
edited
Loading

This PR adds the referencing syntax for StepActions in Stpes. It also adds the necessary conversion between v1beta1 and v1 and the necessary validation. The actual resolution of the referenced StepAction will be implemented in a followup PR.

This is the third item on the implementation Issue #7259

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[WIP] Introduces referencing syntax for StepAction in Steps

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 25, 2023
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 25, 2023
This was referenced Oct 25, 2023
Closed
Merged
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@jerop jerop changed the title Introduce StepAction referencing syntax in Steps TEP-0142: Introduce StepAction referencing syntax in Steps Oct 25, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

QuanZhang-William
QuanZhang-William reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@QuanZhang-William QuanZhang-William left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chitrang, left some small comments

docs/stepactions.md Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/task_validation_test.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/container_types.go Outdated Show resolved Hide resolved
@chitrangpatel chitrangpatel force-pushed the introduce-step-ref branch 2 times, most recently from 7a11438 to d41efa8 Compare October 25, 2023 22:36
@chitrangpatel
Copy link
Member Author

Thanks Chitrang, left some small comments

Thanks Quan! PTAL, I implemented them.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@chitrangpatel
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@jerop
Copy link
Member

jerop commented Oct 26, 2023

@tektoncd/core-maintainers please take a look 🙏🏾

Yongxuanzhang
Yongxuanzhang reviewed Oct 26, 2023
View reviewed changes
pkg/apis/pipeline/v1/task_validation_test.go Outdated Show resolved Hide resolved
test/parse/yaml.go Outdated Show resolved Hide resolved
@chitrangpatel
Introduce StepAction referencing syntax in Steps
f96950d 
This PR adds the referencing syntax for `StepActions` in `Stpes`.
It also adds the necessary conversion between `v1beta1` and `v1`
and the necessary validation.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 97.3% 98.1% 0.9
pkg/apis/pipeline/v1beta1/task_validation.go 97.3% 98.2% 0.9

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, QuanZhang-William, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop jerop added this to the Pipelines v0.54 milestone Oct 26, 2023
@jerop
Copy link
Member

jerop commented Oct 27, 2023

thank you for breaking down this work @chitrangpatel 🙏🏾

/lgtm

adding this note as suggested in tektoncd/community#1097 (comment):

sought more input here and on slack but haven't received any yet, we already have 3 approvals and this is specific change was discussed in a TEP plus it can be easily changed if needed (alpha), so merging to unblock progress for this series of pull requests targeting v0.54

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@tekton-robot tekton-robot merged commit 43ac007 into tektoncd:main Oct 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@QuanZhang-William QuanZhang-William QuanZhang-William approved these changes

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.54
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chitrangpatel @tekton-robot @jerop @QuanZhang-William @Yongxuanzhang