[TEP-0142] Remote Resolution for StepAction #7321

Yongxuanzhang · 2023-11-01T17:23:59Z

Changes

This commit is part of #7259. It adds the remote resolution for StepAction.

/kind feature

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Support Remote Resolution for StepAction

tekton-robot · 2023-11-01T17:24:02Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Yongxuanzhang · 2023-11-01T17:24:15Z

/test all

tekton-robot · 2023-11-01T17:32:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	92.6%	84.0%	-8.6
pkg/reconciler/taskrun/taskrun.go	85.4%	85.3%	-0.0

tekton-robot · 2023-11-01T17:34:37Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	92.6%	84.0%	-8.6
pkg/reconciler/taskrun/taskrun.go	85.4%	85.3%	-0.0

Yongxuanzhang · 2023-11-01T19:04:36Z

/test pull-tekton-pipeline-unit-tests

tekton-robot · 2023-11-01T19:13:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	92.6%	93.6%	1.0
pkg/reconciler/taskrun/taskrun.go	85.4%	85.3%	-0.0

Yongxuanzhang · 2023-11-01T19:28:10Z

pkg/reconciler/taskrun/resources/taskspec.go

@@ -51,7 +54,7 @@ type GetTaskRun func(string) (*v1.TaskRun, error)
 // GetTaskData will retrieve the Task metadata and Spec associated with the
 // provided TaskRun. This can come from a reference Task or from the TaskRun's
 // metadata and embedded TaskSpec.
-func GetTaskData(ctx context.Context, taskRun *v1.TaskRun, getTask GetTask, getStepAction GetStepAction) (*resolutionutil.ResolvedObjectMeta, *v1.TaskSpec, error) {
+func GetTaskData(ctx context.Context, taskRun *v1.TaskRun, getTask GetTask, tekton clientset.Interface, k8s kubernetes.Interface, requester remoteresource.Requester) (*resolutionutil.ResolvedObjectMeta, *v1.TaskSpec, error) {


another way not to pass those clients, requester here, is to move steps, err := extractStepActions(ctx, taskSpec, taskRun, tekton, k8s, requester) out of this GetTaskData.

Yongxuanzhang · 2023-11-01T20:13:24Z

/test pull-tekton-pipeline-unit-tests

tekton-robot · 2023-11-01T20:17:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	92.6%	93.6%	1.0
pkg/reconciler/taskrun/resources/taskspec.go	100.0%	97.9%	-2.1
pkg/reconciler/taskrun/taskrun.go	85.4%	84.2%	-1.2

tekton-robot · 2023-11-02T17:31:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	92.6%	93.6%	1.0
pkg/reconciler/taskrun/resources/taskspec.go	100.0%	97.9%	-2.1
pkg/reconciler/taskrun/taskrun.go	85.4%	84.2%	-1.2

Yongxuanzhang · 2023-11-02T18:16:54Z

/test pull-tekton-pipeline-unit-tests

tekton-robot · 2023-11-02T18:25:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	94.4%	-2.3
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.7%	0.1
pkg/reconciler/taskrun/resources/taskspec.go	100.0%	97.9%	-2.1
pkg/reconciler/taskrun/taskrun.go	85.4%	84.9%	-0.5

jerop · 2023-11-02T18:26:32Z

@tektoncd/core-maintainers @tektoncd/core-collaborators please take a look 🙏🏾

Yongxuanzhang · 2023-11-02T18:51:39Z

@tektoncd/core-maintainers @tektoncd/core-collaborators please take a look 🙏🏾

Thanks, but this PR is not ready yet, I'm adding tests to improve the coverage. 😂

Yongxuanzhang · 2023-11-02T19:17:08Z

/test pull-tekton-pipeline-unit-tests

tekton-robot · 2023-11-02T19:22:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.7%	0.1
pkg/reconciler/taskrun/taskrun.go	85.4%	85.6%	0.2

tekton-robot · 2023-11-02T20:00:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.4%	85.6%	0.2

tekton-robot · 2023-11-05T22:55:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

tekton-robot · 2023-11-05T22:57:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.4%	85.4%	0.0

examples/v1/taskruns/alpha/stepaction-git-resolver.yaml

chitrangpatel · 2023-11-06T19:39:55Z

Thanks for all your help here @Yongxuanzhang 🎉

/approve

tekton-robot · 2023-11-06T19:40:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chitrangpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

docs/stepactions.md

pkg/reconciler/taskrun/resources/taskref.go

pkg/apis/pipeline/v1/taskrun_types.go

pkg/reconciler/taskrun/resources/taskref.go

tekton-robot · 2023-11-07T15:44:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T15:44:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T15:48:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T15:48:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T15:50:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T15:50:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T15:56:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T16:41:38Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T16:42:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

Yongxuanzhang · 2023-11-07T18:29:05Z

/retest
https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/7321/pull-tekton-pipeline-integration-tests/1721928886402420736
'The step "write" in TaskRun "pr-parameterized-subpath-qzkv6-writer-2"
failed to pull the image "". The pod errored with the message: "Back-off pulling
image "ubuntu"."'

This commit is part of tektoncd#7259. It adds the remote resolution for StepAction. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

tekton-robot · 2023-11-07T22:03:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

tekton-robot · 2023-11-07T22:06:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/apiserver/apiserver.go	96.8%	97.2%	0.4
pkg/reconciler/taskrun/resources/taskref.go	92.6%	92.6%	0.0
pkg/reconciler/taskrun/taskrun.go	85.6%	85.6%	0.0

Yongxuanzhang · 2023-11-07T22:47:18Z

/retest

jerop

Thank you @Yongxuanzhang 🎉
/lgtm

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 1, 2023

tekton-robot requested review from dibyom and jerop November 1, 2023 17:24

Yongxuanzhang requested review from chitrangpatel and removed request for dibyom and jerop November 1, 2023 17:24

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2023

Yongxuanzhang commented Nov 1, 2023

View reviewed changes

Yongxuanzhang mentioned this pull request Nov 1, 2023

TEP-0142: Enable Step Reusability - Implementation #7259

Closed

20 tasks

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2023

Yongxuanzhang mentioned this pull request Nov 2, 2023

TEP-0142: Use StepAction from Catalog in example #7325

Open

Yongxuanzhang force-pushed the stepaction-remoteresolution branch from 8ff2d92 to c2d2f48 Compare November 5, 2023 22:47

chitrangpatel reviewed Nov 6, 2023

View reviewed changes

examples/v1/taskruns/alpha/stepaction-git-resolver.yaml Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023

jerop reviewed Nov 7, 2023

View reviewed changes

Yongxuanzhang force-pushed the stepaction-remoteresolution branch from b6372c4 to 6fda995 Compare November 7, 2023 15:38

Yongxuanzhang requested a review from jerop November 7, 2023 15:39

Yongxuanzhang force-pushed the stepaction-remoteresolution branch from 6fda995 to 62defe2 Compare November 7, 2023 16:33

[TEP-0142] Remote Resolution for StepAction

87bcb3c

This commit is part of tektoncd#7259. It adds the remote resolution for StepAction. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Yongxuanzhang force-pushed the stepaction-remoteresolution branch from 62defe2 to 87bcb3c Compare November 7, 2023 21:56

jerop reviewed Nov 8, 2023

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023

tekton-robot merged commit 15c8168 into tektoncd:main Nov 8, 2023
12 checks passed

jerop added this to the Pipelines v0.54 milestone Nov 9, 2023

[TEP-0142] Remote Resolution for StepAction #7321

[TEP-0142] Remote Resolution for StepAction #7321

Conversation

Yongxuanzhang commented Nov 1, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Nov 1, 2023

Yongxuanzhang commented Nov 1, 2023

tekton-robot commented Nov 1, 2023

tekton-robot commented Nov 1, 2023

Yongxuanzhang commented Nov 1, 2023

tekton-robot commented Nov 1, 2023

Yongxuanzhang Nov 1, 2023

Choose a reason for hiding this comment

Yongxuanzhang commented Nov 1, 2023

tekton-robot commented Nov 1, 2023

tekton-robot commented Nov 2, 2023

Yongxuanzhang commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

jerop commented Nov 2, 2023

Yongxuanzhang commented Nov 2, 2023

Yongxuanzhang commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 2, 2023

tekton-robot commented Nov 5, 2023

tekton-robot commented Nov 5, 2023

chitrangpatel commented Nov 6, 2023

tekton-robot commented Nov 6, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

Yongxuanzhang commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

tekton-robot commented Nov 7, 2023

Yongxuanzhang commented Nov 7, 2023

jerop left a comment

Choose a reason for hiding this comment

Yongxuanzhang commented Nov 1, 2023 •

edited

Loading