Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTTP/2 by updating knative/pkg #7324

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Nov 2, 2023

This disables HTTP/2 for webhook by updating to PR knative/pkg#2875 It fixes CVE-2023-44487.

Closes #7235

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

This disables HTTP/2 for webhooks by updating knative/pkg dependency.

This disables HTTP/2 for webhook by updating to PR knative/pkg#2875
It fixes CVE-2023-44487.
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 2, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2023
@khrm
Copy link
Contributor Author

khrm commented Nov 2, 2023

/assign @vdemeester @JeromeJu @dibyom @afrittoli

@khrm
Copy link
Contributor Author

khrm commented Nov 2, 2023

/kind security

@tekton-robot tekton-robot added the kind/security Categorizes issue or PR as related to a security issue label Nov 2, 2023
@khrm
Copy link
Contributor Author

khrm commented Nov 2, 2023

/cherry-pick release-v0.53.x

@tekton-robot
Copy link
Collaborator

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.53.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

Updating the description to mark that it fixes #7235.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@khrm
Copy link
Contributor Author

khrm commented Nov 2, 2023

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@tekton-robot tekton-robot merged commit c2b5f68 into tektoncd:main Nov 2, 2023
12 checks passed
@tekton-robot
Copy link
Collaborator

@khrm: #7324 failed to apply on top of branch "release-v0.53.x":

Applying: Disable HTTP/2 by updating knative/pkg
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Disable HTTP/2 by updating knative/pkg
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm
Copy link
Contributor Author

khrm commented Nov 2, 2023

It seems we need to manually cherry-pick this for v0.53.x.

@khrm khrm deleted the webhook-http2-main branch November 2, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/security Categorizes issue or PR as related to a security issue lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable HTTP/2 for webhook
4 participants