TEP-0142: Surface step results via sidecar logs #7414

chitrangpatel · 2023-11-23T17:17:26Z

Prior to this, we enabled surfacing Step Results via termination-message. This PR does the same thing for sidecar-logs. It would ensure that we can use StepResults when results-from: sidecar-logs feature flag is enabled.

This PR is part of issue #7259.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Surface step results via sidecar logs

/kind feature

tekton-robot · 2023-11-23T17:24:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.3%	93.6%	0.3
pkg/entrypoint/entrypointer.go	87.6%	87.0%	-0.6
pkg/pod/entrypoint.go	93.4%	94.1%	0.7
pkg/pod/pod.go	92.7%	90.2%	-2.4
pkg/pod/status.go	91.7%	90.7%	-1.0
pkg/reconciler/taskrun/resources/apply.go	99.3%	99.4%	0.0
pkg/result/result.go	85.7%	86.7%	1.0

tekton-robot · 2023-11-23T17:25:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.3%	93.6%	0.3
pkg/entrypoint/entrypointer.go	87.6%	87.0%	-0.6
pkg/pod/entrypoint.go	93.4%	94.1%	0.7
pkg/pod/pod.go	92.7%	90.2%	-2.4
pkg/pod/status.go	91.7%	90.7%	-1.0
pkg/reconciler/taskrun/resources/apply.go	99.3%	99.4%	0.0
pkg/result/result.go	85.7%	86.7%	1.0

tekton-robot · 2023-11-23T18:51:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	92.7%	90.2%	-2.4
pkg/pod/status.go	92.1%	90.7%	-1.4

tekton-robot · 2023-11-23T18:52:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	92.7%	90.2%	-2.4
pkg/pod/status.go	92.1%	90.7%	-1.4

examples/v1/taskruns/alpha/stepaction-results.yaml

internal/sidecarlogresults/sidecarlogresults.go

tekton-robot · 2023-11-23T19:54:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	93.1%	1.0

tekton-robot · 2023-11-23T20:30:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.4%	1.4
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	93.1%	1.0

tekton-robot · 2023-11-23T20:30:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.4%	1.4
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	93.1%	1.0

QuanZhang-William · 2023-11-23T20:53:08Z

/lgtm

tekton-robot · 2023-11-23T20:53:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.6%	1.6
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	92.9%	0.8

tekton-robot · 2023-11-23T20:55:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.6%	1.6
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	92.9%	0.8

pkg/pod/pod.go

tekton-robot · 2023-11-23T21:19:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Yongxuanzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2023-11-23T21:20:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.6%	1.6
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	92.9%	0.8

tekton-robot · 2023-11-23T21:22:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.6%	1.6
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	92.9%	0.8

tekton-robot · 2023-11-23T21:36:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.6%	1.6
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	92.9%	0.8

tekton-robot · 2023-11-23T21:37:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.6%	1.6
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	92.9%	0.8

Prior to this, we enabled surfacing step results via termination message. This PR does the same thing via sidecar logs.

tekton-robot · 2023-11-23T21:56:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.6%	1.6
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	92.9%	0.8

tekton-robot · 2023-11-23T21:58:17Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/sidecarlogresults/sidecarlogresults.go	88.0%	89.6%	1.6
pkg/pod/pod.go	92.7%	92.2%	-0.5
pkg/pod/status.go	92.1%	92.9%	0.8

QuanZhang-William · 2023-11-24T01:54:31Z

/lgtm

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 23, 2023

tekton-robot requested review from bobcatfish and jerop November 23, 2023 17:17

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 23, 2023

chitrangpatel marked this pull request as draft November 23, 2023 17:47

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2023

chitrangpatel mentioned this pull request Nov 23, 2023

TEP-0142: Enable Step Reusability - Implementation #7259

Closed

20 tasks

chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 0cd5f90 to 8349b82 Compare November 23, 2023 18:43

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 23, 2023

chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 8349b82 to ed4d578 Compare November 23, 2023 18:45

QuanZhang-William reviewed Nov 23, 2023

View reviewed changes

examples/v1/taskruns/alpha/stepaction-results.yaml Show resolved Hide resolved

internal/sidecarlogresults/sidecarlogresults.go Outdated Show resolved Hide resolved

chitrangpatel force-pushed the step-action-results-sidecar-logs branch from ed4d578 to 071bb40 Compare November 23, 2023 19:46

Yongxuanzhang reviewed Nov 23, 2023

View reviewed changes

internal/sidecarlogresults/sidecarlogresults.go Show resolved Hide resolved

chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 071bb40 to 4702d23 Compare November 23, 2023 20:23

chitrangpatel marked this pull request as ready for review November 23, 2023 20:23

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2023

tekton-robot requested review from abayer and pritidesai November 23, 2023 20:23

chitrangpatel requested review from Yongxuanzhang and QuanZhang-William November 23, 2023 20:23

chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 4702d23 to cb14e57 Compare November 23, 2023 20:47

tekton-robot assigned QuanZhang-William Nov 23, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023

chitrangpatel force-pushed the step-action-results-sidecar-logs branch from cb14e57 to b099f62 Compare November 23, 2023 21:13

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023

Yongxuanzhang approved these changes Nov 23, 2023

View reviewed changes

pkg/pod/pod.go Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023

chitrangpatel force-pushed the step-action-results-sidecar-logs branch from b099f62 to 0fcca32 Compare November 23, 2023 21:29

TEP-0142: Surface step results via sidecar logs

cbd3850

Prior to this, we enabled surfacing step results via termination message. This PR does the same thing via sidecar logs.

chitrangpatel force-pushed the step-action-results-sidecar-logs branch from 0fcca32 to cbd3850 Compare November 23, 2023 21:49

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023

tekton-robot merged commit 30540fc into tektoncd:main Nov 24, 2023
13 checks passed

ericzzzzzzz mentioned this pull request Apr 22, 2024

feat: Surface artifacts through sidecar container logs. #7883

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEP-0142: Surface step results via sidecar logs #7414

TEP-0142: Surface step results via sidecar logs #7414

chitrangpatel commented Nov 23, 2023 •

edited

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

QuanZhang-William commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

QuanZhang-William commented Nov 24, 2023

TEP-0142: Surface step results via sidecar logs #7414

TEP-0142: Surface step results via sidecar logs #7414

Conversation

chitrangpatel commented Nov 23, 2023 • edited

Changes

Submitter Checklist

Release Notes

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

QuanZhang-William commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

tekton-robot commented Nov 23, 2023

QuanZhang-William commented Nov 24, 2023

chitrangpatel commented Nov 23, 2023 •

edited