Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0142: Introduce WorkingDir in StepActions #7461

Merged
merged 1 commit into from
Dec 14, 2023
Merged

TEP-0142: Introduce WorkingDir in StepActions #7461

merged 1 commit into from
Dec 14, 2023

Conversation

chitrangpatel
Copy link
Member

@chitrangpatel chitrangpatel commented Dec 6, 2023 •
edited by jerop

This PR introduces workingDir into StepActions. This allows the StepAction to set the workingDir and work relative to it.

https://github.com/tektoncd/community/blob/main/teps/0142-enable-step-reusability.md#workingdir

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Introduce WorkingDir in StepActions

/kind feature

@chitrangpatel
TEP-0142: Introduce WorkingDir in StepActions
f7e5829 
This PR introduces `workingDir` into `StepActions`. This allows
the `StepAction` to set the `workingDir` and work relative to it.
@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 6, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2023
@chitrangpatel
Copy link
Member Author

/hold wait for tektoncd/community#1119 to be merged first

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
@chitrangpatel
Copy link
Member Author

chitrangpatel commented Dec 6, 2023 •
edited

/assign @vdemeester @afrittoli @wlynch (please review after tektoncd/community#1119)

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% 0.0

@chitrangpatel
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@chitrangpatel
Copy link
Member Author

This can now be reviewed. cc @Yongxuanzhang @jerop

@Yongxuanzhang
Copy link
Member

/assign

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
jerop
jerop approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 5e3b0dc into tektoncd:main Dec 14, 2023
13 checks passed
@jerop jerop mentioned this pull request Dec 14, 2023
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop jerop approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@jerop jerop

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chitrangpatel @tekton-robot @Yongxuanzhang @vdemeester @jerop