kind/feature : populate-params-and-results-to-workspace-bindings

[ericzzzzzzz]

Changes

fixes: #6384

• Support for variable interpolation in workspace.* (in PipelineRun and TaskRun)
• Note that: AffinityAssistant must be disabled to use tasks.results for pvc in pipeline, as AffinityAssistant is created before all tasks and the pod annotation for affinity only has a place holder, the taskRun creation will fail due to unable to find suitable node.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Populate params and results to workspace bindings.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ericzzzzzzz (331e939, 21765c1, 39654b8, c351495, be212f9, 5b237d8, aa5315c, 68003eb, 0bc1593, e35fb2d, 9bd534d, 5cda0c0)

[tekton-robot]

Hi @ericzzzzzzz. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	90.8%	-1.4
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.1%	-0.4
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	99.2%	98.3%	-0.8
pkg/reconciler/taskrun/taskrun.go	85.2%	84.4%	-0.9

[chitrangpatel]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	90.8%	-1.4
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.1%	-0.4
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	99.2%	98.3%	-0.8
pkg/reconciler/taskrun/taskrun.go	85.2%	84.4%	-0.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	90.8%	-1.4
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.1%	-0.4
pkg/reconciler/taskrun/taskrun.go	85.2%	85.8%	0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	91.0%	-1.2
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.1%	-0.4
pkg/reconciler/taskrun/taskrun.go	85.2%	85.8%	0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.4%	0.2
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.1%	-0.4
pkg/reconciler/taskrun/taskrun.go	85.2%	85.8%	0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.4%	0.2
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.1%	-0.4
pkg/reconciler/taskrun/taskrun.go	85.2%	85.8%	0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.4%	0.2
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.1%	-0.4
pkg/reconciler/taskrun/taskrun.go	85.2%	85.8%	0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.3%	0.1
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	90.0%	-8.4
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.5%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	97.3%	-1.1
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.5%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	97.3%	-1.2
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.4%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	97.3%	-1.2
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.4%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[vdemeester]

Looks good, but I have one question : is it intentional to not support the csi workspace binding ? I don't really see any reason to support all (pvc, claimtemplate, secret, configmap and projected) but csi 🤔

[ericzzzzzzz]

@vdemeester

Looks good, but I have one question : is it intentional to not support the csi workspace binding ? I don't really see any reason to support all (pvc, claimtemplate, secret, configmap and projected) but csi 🤔

ahh, sorry I thought we just wanted the fields listed on the issue. I'll add support for csi,

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	96.4%	-2.1
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.5%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	96.4%	-2.1
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.5%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JeromeJu,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chitrangpatel]

/assign

[chitrangpatel]

Almost lgtm. Just need coverage on the places I highlighted I think. They are untested.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	97.7%	-0.7
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.5%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	97.7%	-0.7
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.5%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.7%	0.2
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.5%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	92.2%	92.2%	0.0
pkg/reconciler/pipelinerun/resources/apply.go	98.4%	98.7%	0.2
pkg/reconciler/taskrun/resources/apply.go	99.4%	99.5%	0.1
pkg/reconciler/taskrun/taskrun.go	85.2%	85.2%	0.0

[chitrangpatel]

Thanks @ericzzzzzzz 🎉
/lgtm