Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0075(object params and results) promoted to stable #7544

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Jan 3, 2024

Changes

Pipeline 0.46 introduced object params and results. This commit is promoting TEP-0075 to stable such that these features can be used by the task authors and pipeline authors in a cluster when enable-api-fields is alpha, beta or stable.

Closes #6748

/kind feature

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

TEP-0075 promoted to stable - object params and results is now possible with enable-api-fields set to stable.

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 3, 2024
@Yongxuanzhang
Copy link
Member Author

/test all

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jan 3, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.3
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.0% -0.3
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.0

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2024
@Yongxuanzhang
Copy link
Member Author

/test all

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.0

Pipeline 0.46  introduced object params and results. This commit is
promoting TEP-0075 to stable such that these features can be used by
the task authors and pipeline authors in a cluster when enable-api-fields is alpha,beta or stable.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review January 4, 2024 19:48
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 96.9% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 96.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 96.9% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 96.9% -0.0

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@chitrangpatel
Copy link
Member

Thanks @Yongxuanzhang for shepherding this to stable 🎉
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
@tekton-robot tekton-robot merged commit fe47c9b into tektoncd:main Jan 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote TEP-75 from Beta to Stable
4 participants